Till Westmann has posted comments on this change. Change subject: Allow lazy loading for persistent local resources ......................................................................
Patch Set 5: (7 comments) Just a few small comments. https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java: Line 290: ILSMIndex lsmIndex = (ILSMIndex) indexLifecycleManager.getIndex(metadataIndex.getFile().toString()); Could we create a local variable for "metadataIndex.getFile().toString()"? Line 639: ILSMIndex lsmIndex = (ILSMIndex) indexLifecycleManager.getIndex(metadataIndex.getFile().toString()); Could we create a local variable for "metadataIndex.getFile().toString()"? Line 973: IIndex indexInstance = indexLifecycleManager.getIndex(index.getFile().toString()); Could we create a local variable for "index.getFile().toString()"? Line 1049: IIndex indexInstance = indexLifecycleManager.getIndex(index.getFile().toString()); Could we create a local variable for "index.getFile().toString()"? Line 1087: .toString()); Another local variable here? https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/pom.xml File asterix-transactions/pom.xml: Line 11: xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> This seems to be a modification in the wrong direction. We shouldn't introduce tabs. https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: Line 48: private final Cache<String, LocalResource> resourcesCache; > OK, fine for me. (though in many other places in the codebase, we usually u I'd prefer "resourceCache" as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/344 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
