Murtadha Hubail has posted comments on this change. Change subject: Allow lazy loading for persistent local resources ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/344/5/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: Line 205: public HashMap<Long, LocalResource> loadAndGetAllResources() throws HyracksDataException { > IMO, "slower" is better than "crashing when too many resources"... 1. I added the comment in the coming patch. When I'm done with fault tolerance implementation, we will have the partition number in the log. That could narrow down the search for specific resource on disk. 2. The call in initialize was a redundant call. I removed it completely. I implemented getMaxResourceId and used it in ResourceIdFactoryProvider. -- To view, visit https://asterix-gerrit.ics.uci.edu/344 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
