----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63462/#review192255 -----------------------------------------------------------
I tried this patch on atlas-master (0900 UTC 20171130), maven 3.5.0, java 8 (b152), macOS. Built clean. Server started, but seemed very slow to do so application.log showing many errors - including zookeeper every 1s quick_start failed (503/service unavailable) UI fails (503/service unavailable) script for titan054 etc on mail list did pass the above (some errors, but many less) Conclusion: patch doesn't work for me - Nigel Jones On Nov. 3, 2017, 7:56 a.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63462/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2017, 7:56 a.m.) > > > Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan > Neethiraj, and Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > ATLAS-2245: Update maven dependency to 3.5.0 > Also updated Java Dependency to 8 > Both are enforced in the top level POM using the maven enforcer plugin > Initial implementation used the 'dependencies' tag in the pom. However this > is deprecated, not inherited, and was primarily intended for plugins rather > than projects. > > THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. > Many users will need to update maven in particular > > > Diffs > ----- > > pom.xml 5a6add64 > > > Diff: https://reviews.apache.org/r/63462/diff/3/ > > > Testing > ------- > > Test with mvn clean install > > If Maven version is not 3.5.0: > [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ > apache-atlas --- > [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion > failed with message: > ** Please upgrade maven to 3.5.2 or above. See > https://maven.apache.org/install.html > > Similar for Java > > If dependencies met, build continues ok > > Proposed (in Jira) to update wiki page & send out email on dist list due to > developer impact > THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7. > Many users will need to update maven in particular > > > Thanks, > > Nigel Jones > >
