-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63462/
-----------------------------------------------------------

(Updated Dec. 13, 2017, 11:16 a.m.)


Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan 
Neethiraj, and Mandy Chessell.


Changes
-------

Updated patch
 - Merged manually back into current master (the POM had changed with other 
dependencies and patch wouldn't apply)
 - removed JIRA reference in comment
 - Modified check to validate Java 8 is at 1.8.0-151 or above (this is current, 
and has been for a month or two. actually 152 is out, but this seems the most 
prudent one to go with). An earlier version will fail the build
 - Added a 'WARNING' if Java 9 or above is used - to simply state it's intested 
with Atlas. This does NOT stop the build
 - Updated messages to be more direct/prescriptive


Repository: atlas


Description
-------

ATLAS-2245: Update maven dependency to 3.5.0
Also updated Java Dependency to 8
Both are enforced in the top level POM using the maven enforcer plugin
Initial implementation used the 'dependencies' tag in the pom. However this is 
deprecated, not inherited, and was primarily intended for plugins rather than 
projects. 

THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7.
Many users will need to update maven in particular


Diffs (updated)
-----

  pom.xml 3b9a464b 


Diff: https://reviews.apache.org/r/63462/diff/4/

Changes: https://reviews.apache.org/r/63462/diff/3-4/


Testing
-------

Test with mvn clean install

If Maven version is not 3.5.0:
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ 
apache-atlas ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed 
with message:
** Please upgrade maven to 3.5.2 or above. See 
https://maven.apache.org/install.html

Similar for Java

If dependencies met, build continues ok

Proposed (in Jira) to update wiki page & send out email on dist list due to 
developer impact
THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7.
Many users will need to update maven in particular


Thanks,

Nigel Jones

Reply via email to