> On Dec. 13, 2017, 12:05 p.m., Graham Wallis wrote:
> > I think it would be preferable to also update graphdb/janus/pom.xml so that
> > it uses a consistent version of the enforcer plugin and specifies the same
> > requiremenets for java and maven versions - preferably simply inheriting
> > them from the root pom if possible.
> > There should be no need to make similar changes to titan1/pomx.ml as titan1
> > is being retired by ATLAS-2308.
I can generate another patch which removes those changes (I'd missed the fact
they'd got added given the time between this initial proposal and the janus
integration). That should be fine as we'll inherit?
That would remove this from graphdb/janus/pom.xml - the only place I see
maven-enforcer
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>1.4.1</version>
<executions>
<execution>
<id>enforce-java-8</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireJavaVersion>
<version>1.8.0</version>
</requireJavaVersion>
<requireMavenVersion>
<version>3.1.0</version>
</requireMavenVersion>
</rules>
</configuration>
</execution>
</executions>
</plugin>
- Nigel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63462/#review193673
-----------------------------------------------------------
On Dec. 13, 2017, 11:25 a.m., Nigel Jones wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63462/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 11:25 a.m.)
>
>
> Review request for atlas, Apoorv Naik, David Radley, Graham Wallis, Madhan
> Neethiraj, and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2245: Update maven dependency to 3.5.0
> Also updated Java Dependency to 8
> Both are enforced in the top level POM using the maven enforcer plugin
> Initial implementation used the 'dependencies' tag in the pom. However this
> is deprecated, not inherited, and was primarily intended for plugins rather
> than projects.
>
> THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7.
> Many users will need to update maven in particular
>
>
> Diffs
> -----
>
> pom.xml 3b9a464b
>
>
> Diff: https://reviews.apache.org/r/63462/diff/4/
>
>
> Testing
> -------
>
> Test with mvn clean install
>
> If Maven version is not 3.5.0:
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @
> apache-atlas ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion
> failed with message:
> ** Please upgrade maven to 3.5.2 or above. See
> https://maven.apache.org/install.html
>
> Similar for Java
>
> If dependencies met, build continues ok
>
> Proposed (in Jira) to update wiki page & send out email on dist list due to
> developer impact
> THIS MEANS YOU CANNOT BUILD with earlier maven versions OR Java 7.
> Many users will need to update maven in particular
>
> -- Update with 13 Dec patch --
> * Tested with mvn clean install
> * Checked JDK 1.8/151 or 152 works, that < 151 fails, and that Java 9
> produces a warning
> * Checked maven 3.5.0 or above works, earlier fails
>
> Also checked build environment - from build logs build server is using maven
> 3.5.2 & java 1.8.0_152
>
> **** -->
> REVIEW QUESTION - I went with 3.5.0 (as Apache ranger hit bugs with 3.5.2..
> though that was only with enuciate), and java 1.8.0_151 (as I know many have
> that, and it's easy to select when downloading). OK???
> **** --<
>
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=1024m;
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T07:58:13Z)
> Maven home: /home/jenkins/tools/maven/latest
> Java version: 1.8.0_152, vendor: Oracle Corporation
> Java home: /usr/local/asfpackages/java/jdk1.8.0_152/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-43-generic", arch: "amd64", family: "unix"
> + java -version
> java version "1.8.0_152"
> Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
> Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)
>
> Example of failure errors:
>
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @
> apache-atlas ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed
> with message:
> ** JAVA VERSION ERROR ** Java 8 (b151) or above is required.
>
>
> or
>
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @
> apache-atlas ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion
> failed with message:
> ** MAVEN VERSION ERROR ** Maven 3.5.0 or above is required. See
> https://maven.apache.org/install.html
> [WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireJavaVersion warned
> with message:
> ** JAVA VERSION WARNING ** Java 9 and above has not been tested with Atlas.
>
>
> Thanks,
>
> Nigel Jones
>
>
