----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64902/#review194680 -----------------------------------------------------------
Instead of having the indexing backend startup classes in test scope. I think it's better to create a submodule, where we can put such server startup classes and then the tests or production code can rely on the module for starting all embedded dependencies. This might help in reducing the amount of POM configuration we have put in after introduction of Janus graph common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java Lines 134 (patched) <https://reviews.apache.org/r/64902/#comment273616> Something else => bad arguments graphdb/janus/pom.xml Line 169 (original) <https://reviews.apache.org/r/64902/#comment273617> Can you ensure that the test-jar is not present within distro war? graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java Lines 172 (patched) <https://reviews.apache.org/r/64902/#comment273618> Avoid printing stacktrace pom.xml Line 595 (original), 595 (patched) <https://reviews.apache.org/r/64902/#comment273615> Reason for downgrade ? repository/pom.xml Line 170 (original) <https://reviews.apache.org/r/64902/#comment273619> Please ensure that the test jar is not included in the distro war. Check other such occurences too - Apoorv Naik On Jan. 3, 2018, 12:46 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64902/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 12:46 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2331 > https://issues.apache.org/jira/browse/ATLAS-2331 > > > Repository: atlas > > > Description > ------- > > JanusGraph 0.2.0 doesn't provide option to start its own indexing backend > when started in embedded mode. This JIRA provides an option to start a local > solr server before the IntegrationTest runs. > > > Diffs > ----- > > common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4 > graphdb/janus/pom.xml 738cac9e > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > e507a8ad > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > d764da4a > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java > 7c33f10b > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java > fd062568 > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java > 33c8296c > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 80dc5142 > pom.xml d472ae7c > repository/pom.xml 7096ddfc > repository/src/main/java/org/apache/atlas/solr/EmbeddedSolrServer.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 456a7784 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 4256043f > webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java > e65d6789 > > > Diff: https://reviews.apache.org/r/64902/diff/1/ > > > Testing > ------- > > Validated that the local solr server is started before the run of ITs in > webapp module. > > To run ITs: > mvn clean install -DskipUTs > > We still see IT failures in webapp module, this will be addressed in > ATLAS-2330 > > > Thanks, > > Sarath Subramanian > >
