> On Jan. 3, 2018, 10:19 p.m., Apoorv Naik wrote: > > common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java > > Lines 142 (patched) > > <https://reviews.apache.org/r/64902/diff/4/?file=1930171#file1930171line155> > > > > Avoid printing stack traces if possible.
ah, I thought I removed this. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64902/#review194735 ----------------------------------------------------------- On Jan. 3, 2018, 9 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64902/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 9 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2331 > https://issues.apache.org/jira/browse/ATLAS-2331 > > > Repository: atlas > > > Description > ------- > > JanusGraph 0.2.0 doesn't provide option to start its own indexing backend > when started in embedded mode. This JIRA provides an option to start a local > solr server before the IntegrationTest runs. > > > Diffs > ----- > > common/pom.xml 29ce58ea > common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4 > common/src/test/resources/solr/collections.txt > common/src/test/resources/solr/core-template/currency.xml > common/src/test/resources/solr/core-template/lang/stopwords_en.txt > common/src/test/resources/solr/core-template/protwords.txt > common/src/test/resources/solr/core-template/schema.xml > common/src/test/resources/solr/core-template/solrconfig.xml > common/src/test/resources/solr/core-template/stopwords.txt > common/src/test/resources/solr/core-template/synonyms.txt > common/src/test/resources/solr/solr.xml > graphdb/janus/pom.xml 738cac9e > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > e507a8ad > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > d764da4a > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java > 7c33f10b > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java > fd062568 > pom.xml d472ae7c > repository/pom.xml 7096ddfc > test-tools/pom.xml PRE-CREATION > test-tools/src/main/resources/log4j.properties PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 4256043f > webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java > e65d6789 > > > Diff: https://reviews.apache.org/r/64902/diff/4/ > > > Testing > ------- > > Validated that the local solr server is started before the run of ITs in > webapp module. > > To run ITs: > mvn clean install -DskipUTs > > We still see IT failures in webapp module, this will be addressed in > ATLAS-2330 > > > Thanks, > > Sarath Subramanian > >
