----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64902/#review194681 -----------------------------------------------------------
pom.xml Line 595 (original), 595 (patched) <https://reviews.apache.org/r/64902/#comment273620> starting with 2.19.1 of surefire, 'skipAfterFailureCount = n' was added which skips remaining tests after 'n' failures. If this property is not set, defaults to 0 - the build reports successfull even if there are test failures and logs in surefire reports. To avoid adding including property -Dsurefire.skipAfterFailureCount=1 everytime when building, downgraded the plugin version. (Tried adding the property in parent pom's plugin property but it did not work for some reason) http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#skipAfterFailureCount - Sarath Subramanian On Jan. 2, 2018, 4:46 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64902/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2018, 4:46 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2331 > https://issues.apache.org/jira/browse/ATLAS-2331 > > > Repository: atlas > > > Description > ------- > > JanusGraph 0.2.0 doesn't provide option to start its own indexing backend > when started in embedded mode. This JIRA provides an option to start a local > solr server before the IntegrationTest runs. > > > Diffs > ----- > > common/src/test/java/org/apache/atlas/runner/LocalSolrRunner.java 33fda1f4 > graphdb/janus/pom.xml 738cac9e > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > e507a8ad > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > d764da4a > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java > 7c33f10b > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java > fd062568 > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java > 33c8296c > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 80dc5142 > pom.xml d472ae7c > repository/pom.xml 7096ddfc > repository/src/main/java/org/apache/atlas/solr/EmbeddedSolrServer.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 456a7784 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 4256043f > webapp/src/test/java/org/apache/atlas/notification/AdaptiveWaiterTest.java > e65d6789 > > > Diff: https://reviews.apache.org/r/64902/diff/1/ > > > Testing > ------- > > Validated that the local solr server is started before the run of ITs in > webapp module. > > To run ITs: > mvn clean install -DskipUTs > > We still see IT failures in webapp module, this will be addressed in > ATLAS-2330 > > > Thanks, > > Sarath Subramanian > >
