> On May 11, 2018, 10:39 a.m., David Radley wrote: > > distro/src/main/assemblies/omag-server.xml > > Lines 29 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019396#file2019396line29> > > > > I am wondering if you should add <fileMode> and > > <directoryMode> like KafkaHook does. We should ensure that the jar and > > sh files are executable and the readme is not. > > > > I see > > -rw-r--r-- 1 david staff 1080 11 May 09:48 README.md > > -rw-r--r-- 1 david staff 8022 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT-sources.jar > > -rw-r--r-- 1 david staff 6561 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT-test-sources.jar > > -rw-r--r-- 1 david staff 17222951 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT.jar > > > > > > It doesn to look like the jar is executable. > > Also why have we got the sources and test sources jar files? > > David Radley wrote: > As it works - I guess we do not need to make it executable. Please could > you review deleting the otehr jars > > Nigel Jones wrote: > Intriguingly when I build it I do not see those jars in the distribution > which only contains the files as per the jira ie > ? > ~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT > [master ?·3?·1|…1? 3] > 10:49 $ ls > README.md omag-server-1.0.0-SNAPSHOT.jar > > I did check this beforehand.. I'll do a clean build again to double check > > Note I am referring here to what goes in the distribution (under > distro/target)... I think I'd leave what's in the component build > (omag-server/target)
On the permissions, I can add those, as it makes sense, but the jar was tested and does work - Nigel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 ----------------------------------------------------------- On May 10, 2018, 5:23 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 5:23 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > ----- > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/1/ > > > Testing > ------- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
