> On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/README.md > > Lines 25 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019397#file2019397line25> > > > > If you lose this whitespace - then we will not get thew white space > > warning on patch apply > > Nigel Jones wrote: > Odd. hadn't noticed that. I still need to understand how it gets there. > Will do.
Difficult to eliminate completely especially in README.md as intellij likes adding space indentation to match prior line even at end of file - in my case indentation was to get block quoting. Trying to fix this has led to other errors so I propose we leave this as-is for now (at least as per current patch). Perhaps there are some intellij settings we can tweak to reduce the likelihood of whitespace - Nigel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 ----------------------------------------------------------- On May 11, 2018, 12:26 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 12:26 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > ----- > > ATLAS-2668a.patch PRE-CREATION > ATLAS-2668b.patch PRE-CREATION > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/4/ > > > Testing > ------- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
