> On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/README.md > > Lines 22 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019397#file2019397line22> > > > > I suggest changing this to be launching the standalone Open Metadata > > And Governance (OMAG) Server. > > Nigel Jones wrote: > Fair comment, though as there's no regression here could do in another > jira for expediency? Can remake patch once we are happy with other issues?
On reflection I propose leaving as is for the following reasons * The title of the readme already uses the full name 'Open Metadata and Governance Server' * OMAG is already referred to in the readme as the abbreviation * The launching ... is only a sub heading within the tiny document * This is a placeholder for a more complete readme we should add about how to use the omag server - so consider it a bootstrap to get started (and an improvement on not having anything) * We should ultimately likely have full start/stop scripts, which should use the wording you describe. However we need to talk a little more on a jira/lists about what that might entail, so I decided to omit for expediency - and I think what we have here offers value now - Nigel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 ----------------------------------------------------------- On May 10, 2018, 5:23 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 5:23 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > ----- > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/1/ > > > Testing > ------- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
