> On Oct. 16, 2019, 8:10 p.m., Na Li wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 175 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line175> > > > > do you want to define types that can be used for hyperparameters? > > > > Can you give me some examples that we can define general purpose types > > to contain hyper parameters?
Floats would be most common, but ints, bools, categoricals and arrays are all possible. @mlw at cloudera could give you some more color. > On Oct. 16, 2019, 8:10 p.m., Na Li wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 197 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line197> > > > > the status can be "deprecated" for example. We need to look from ML > > operation point of view, not from how model build is created. > > > > If operation engineer found some issue on a model build, which will > > then be marked as "deprecated", and some model may be in "dev" stage, and > > some are approved to be in "production". We need those info to help decide > > what model build to deploy. > > > > For different deployment situations, the status can be of different > > values. Making it as enum may be too restrictive. Hmmm. If status can be any user-chosen string, as opposed to an enum, then we aren't going to be able to do much with it in UI or tooling. For example, some users may choose 'deprecated' and some may choose 'stale'. In that case we could leave it to a flexible metadata attribute and keep the type definition small at this stage. We will definitely want to add attributes as we start to get feedback from users. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218238 ----------------------------------------------------------- On Oct. 16, 2019, 12:30 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2019, 12:30 a.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/1000-Hadoop/1111-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/1/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
