> On Oct. 16, 2019, 4:45 p.m., Karthik Manamcheri wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 286 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line286> > > > > What is the purpose of "updatedAt"?
I removed it. if user wants it, can add it in attribute "metadata" > On Oct. 16, 2019, 4:45 p.m., Karthik Manamcheri wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 349 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line349> > > > > How is a ML User different from a regular user? it is a user involved in ML actions. There is no base type we can re-use. __AtlasUserProfile is used internally, totally different purpose from ours. > On Oct. 16, 2019, 4:45 p.m., Karthik Manamcheri wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 447 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line447> > > > > I question the need for a ml_user at this point. I don't completely > > understand how or why a ml_user is different from any other user in the > > system? > > > > Should this just be "user"? I prefix each type with "ml_" to avoid type conflict. Other integration may change to use "user" for a totally different purpose. We do need to have a type for user. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218235 ----------------------------------------------------------- On Oct. 16, 2019, 12:30 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2019, 12:30 a.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/1000-Hadoop/1111-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/1/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
