> On May 7, 2020, 12:21 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > > Lines 995 (patched) > > <https://reviews.apache.org/r/72440/diff/1/?file=2228710#file2228710line995> > > > > entityType could be null when called from FreeTextSearchProcessor. > > Please review and update to handle this condition.
Good point, additional check added. - Damian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/#review220666 ----------------------------------------------------------- On May 13, 2020, 10:51 p.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72440/ > ----------------------------------------------------------- > > (Updated May 13, 2020, 10:51 p.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, > and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > No way to sort results by specified attribute while freetext search is > enabled. In our case we would like to enforce ordering by introducing custom > attribute definition e.g. popularity score from > https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json > > > Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758 > Patched applied against master branch. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > fb12244ed > > repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java > 9850d8ecf > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 11eb7ca49 > > repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java > PRE-CREATION > test-tools/src/main/resources/solr/core-template/solrconfig.xml 9264f99d4 > > > Diff: https://reviews.apache.org/r/72440/diff/2/ > > > Testing > ------- > > Patch was applied on our dev env with custom entity definitions and > successfully verified if order is applied as specified in the search query. > > > Thanks, > > Damian Warszawski > >
