----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/ -----------------------------------------------------------
(Updated May 13, 2020, 10:51 p.m.) Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, and Sarath Subramanian. Changes ------- add unit tests for freetext search processor Repository: atlas Description ------- No way to sort results by specified attribute while freetext search is enabled. In our case we would like to enforce ordering by introducing custom attribute definition e.g. popularity score from https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758 Patched applied against master branch. Diffs (updated) ----- repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java fb12244ed repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 9850d8ecf repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 11eb7ca49 repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java PRE-CREATION test-tools/src/main/resources/solr/core-template/solrconfig.xml 9264f99d4 Diff: https://reviews.apache.org/r/72440/diff/2/ Changes: https://reviews.apache.org/r/72440/diff/1-2/ Testing ------- Patch was applied on our dev env with custom entity definitions and successfully verified if order is applied as specified in the search query. Thanks, Damian Warszawski
