jackhalfalltrades commented on code in PR #307:
URL: https://github.com/apache/atlas/pull/307#discussion_r1996050754
##########
notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java:
##########
@@ -281,9 +300,7 @@ public void sendInternal(String topic, List<String>
messages, boolean isSortNeed
}
public void sendInternal(String topic, List<String> messages) throws
NotificationException {
- KafkaProducer producer = getOrCreateProducer(topic);
-
- sendInternalToProducer(producer, topic, messages);
+ sendInternal(topic, messages, SORT_NOT_NEEDED);
Review Comment:
I am just grouping the similar code remove redundancy. The only difference
between
sendInternalToProducer() -- which is removed
sendInternal() -- which is re-used
Is the sort parameter. everything else is same. Do we still want to have two
methods with almost same functionality ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
