mneethiraj commented on code in PR #307:
URL: https://github.com/apache/atlas/pull/307#discussion_r2011498266
##########
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java:
##########
@@ -122,137 +129,141 @@
@Order(5)
@DependsOn(value = {"atlasTypeDefStoreInitializer",
"atlasTypeDefGraphStoreV2"})
public class NotificationHookConsumer implements Service,
ActiveStateChangeHandler {
- private static final Logger LOG =
LoggerFactory.getLogger(NotificationHookConsumer.class);
- private static final Logger PERF_LOG =
AtlasPerfTracer.getPerfLogger(NotificationHookConsumer.class);
- private static final Logger FAILED_LOG =
LoggerFactory.getLogger("FAILED");
+ private static final Logger LOG =
LoggerFactory.getLogger(NotificationHookConsumer.class);
+ private static final Logger PERF_LOG =
AtlasPerfTracer.getPerfLogger(NotificationHookConsumer.class);
+ private static final Logger FAILED_LOG = LoggerFactory.getLogger("FAILED");
private static final Logger LARGE_MESSAGES_LOG =
LoggerFactory.getLogger("LARGE_MESSAGES");
// from org.apache.hadoop.hive.ql.parse.SemanticAnalyzer
- public static final String DUMMY_DATABASE
= "_dummy_database";
- public static final String DUMMY_TABLE
= "_dummy_table";
- public static final String VALUES_TMP_TABLE_NAME_PREFIX
= "Values__Tmp__Table__";
- public static final String CONSUMER_THREADS_PROPERTY
= "atlas.notification.hook.numthreads";
- public static final String CONSUMER_RETRIES_PROPERTY
= "atlas.notification.hook.maxretries";
- public static final String CONSUMER_FAILEDCACHESIZE_PROPERTY
= "atlas.notification.hook.failedcachesize";
- public static final String CONSUMER_RETRY_INTERVAL
= "atlas.notification.consumer.retry.interval";
- public static final String CONSUMER_MIN_RETRY_INTERVAL
= "atlas.notification.consumer.min.retry.interval";
- public static final String CONSUMER_MAX_RETRY_INTERVAL
= "atlas.notification.consumer.max.retry.interval";
- public static final String CONSUMER_COMMIT_BATCH_SIZE
= "atlas.notification.consumer.commit.batch.size";
- public static final String CONSUMER_DISABLED
= "atlas.notification.consumer.disabled";
- public static final String CONSUMER_SKIP_HIVE_COLUMN_LINEAGE_HIVE_20633
=
"atlas.notification.consumer.skip.hive_column_lineage.hive-20633";
+ public static final String DUMMY_DATABASE = "_dummy_database";
+ public static final String DUMMY_TABLE = "_dummy_table";
+ public static final String VALUES_TMP_TABLE_NAME_PREFIX =
"Values__Tmp__Table__";
+ public static final String CONSUMER_THREADS_PROPERTY =
"atlas.notification.hook.numthreads";
+ public static final String CONSUMER_RETRIES_PROPERTY =
"atlas.notification.hook.maxretries";
+ public static final String CONSUMER_FAILEDCACHESIZE_PROPERTY =
"atlas.notification.hook.failedcachesize";
+ public static final String CONSUMER_RETRY_INTERVAL =
"atlas.notification.consumer.retry.interval";
+ public static final String CONSUMER_MIN_RETRY_INTERVAL =
"atlas.notification.consumer.min.retry.interval";
+ public static final String CONSUMER_MAX_RETRY_INTERVAL =
"atlas.notification.consumer.max.retry.interval";
Review Comment:
Why were these lines updated??
##########
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java:
##########
@@ -92,6 +97,13 @@ public EntityMutationResponse run(EntityImportStream
entityStream, AtlasImportRe
return ret;
}
+ @Override
+ public TypesUtil.Pair<EntityMutationResponse, Float>
run(AtlasEntity.AtlasEntityWithExtInfo entityWithExtInfo,
EntityMutationResponse ret,
+ AtlasImportResult
importResult, Set<String> processedGuids, int entityStreamPosition,
+ int streamSize,
float currentPercent, List<String> residualList) throws AtlasBaseException {
+ return null;
Review Comment:
`throw new NotImplementedException("MigrationImport: entity import not
implemented");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
