jackhalfalltrades commented on code in PR #307:
URL: https://github.com/apache/atlas/pull/307#discussion_r1996057042
##########
notification/src/main/java/org/apache/atlas/notification/rest/RestNotification.java:
##########
@@ -84,6 +84,10 @@ public void sendInternal(NotificationType type, List<String>
messages) throws No
}
}
+ @Override
+ public void sendInternal(String topic, List<String> messages) throws
NotificationException {
+ }
Review Comment:
The implementation of this abstract method provided by AbstractNotification
is currently needed only KafkaNotification. Hence kept the implementation
empty.
##########
notification/src/main/java/org/apache/atlas/notification/spool/Spooler.java:
##########
@@ -81,6 +82,10 @@ public void sendInternal(NotificationType type, List<String>
messages) {
}
}
+ @Override
+ public void sendInternal(String topic, List<String> messages) throws
NotificationException {
+ }
Review Comment:
The implementation of this abstract method provided by AbstractNotification
is currently needed only KafkaNotification. Hence kept the implementation
empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
