UmeshPatil-1 commented on code in PR #490:
URL: https://github.com/apache/atlas/pull/490#discussion_r2939634715
##########
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java:
##########
@@ -271,15 +285,29 @@ public AtlasVertex preDeleteByName(String name) throws
AtlasBaseException {
throw new AtlasBaseException(AtlasErrorCode.TYPE_NAME_NOT_FOUND,
name);
}
- checkBusinessMetadataRef(existingDef.getName());
+ if (!forceDelete) {
+ boolean hasIndexableAttribute = hasIndexableAttribute(existingDef);
- LOG.debug("<== AtlasBusinessMetadataDefStoreV2.preDeleteByName({}):
{}", name, ret);
+ if (!hasIndexableAttribute) {
Review Comment:
cache invalidation complexity is not justified for this deletion-time
decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
