UmeshPatil-1 commented on code in PR #490:
URL: https://github.com/apache/atlas/pull/490#discussion_r3199743428


##########
intg/src/main/java/org/apache/atlas/type/AtlasBusinessMetadataType.java:
##########
@@ -137,6 +151,29 @@ void resolveReferencesPhase2(AtlasTypeRegistry 
typeRegistry) throws AtlasBaseExc
         }
     }
 
+    @Override
+    void resolveReferencesPhase3(AtlasTypeRegistry typeRegistry) throws 
AtlasBaseException {

Review Comment:
   We kept this in `resolveReferencesPhase3` because it expands applicable 
entity types using `getAllSubTypes()`, which is only fully populated after all 
entity types have finished phase 2. Moving it into BM’s phase 2 could run 
before some entities have registered subtypes, so expansion could be incomplete.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to