UmeshPatil-1 commented on code in PR #490:
URL: https://github.com/apache/atlas/pull/490#discussion_r3200022226


##########
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java:
##########
@@ -183,6 +183,7 @@ public enum AtlasErrorCode {
     BLANK_NAME_ATTRIBUTE(400, "ATLAS-400-00-104", "Name Attribute can't be 
empty!"),
     BLANK_VALUE_ATTRIBUTE(400, "ATLAS-400-00-105", "Value Attribute can't be 
empty!"),
     INVALID_RELATIONSHIP_LABEL(400, "ATLAS-400-00-106", "Invalid relationship 
label {0}. The referenced entity type {1} could not be resolved from the type 
registry."),
+    NON_INDEXABLE_BM_DELETE_NOT_ALLOWED(400, "ATLAS-400-00-107", "Deletion not 
allowed for non-indexable Business Metadata ''{0}'' without force=true. 
Non-indexable attributes cannot be validated efficiently for references; use 
force=true to skip validation and delete (warning: orphaned references may 
remain)."),

Review Comment:
   With force=true, Atlas deletes the typedef without checking whether entities 
still hold values for those attributes; such values may remain on entity 
instances until separately cleaned up.



##########
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java:
##########
@@ -183,6 +183,7 @@ public enum AtlasErrorCode {
     BLANK_NAME_ATTRIBUTE(400, "ATLAS-400-00-104", "Name Attribute can't be 
empty!"),
     BLANK_VALUE_ATTRIBUTE(400, "ATLAS-400-00-105", "Value Attribute can't be 
empty!"),
     INVALID_RELATIONSHIP_LABEL(400, "ATLAS-400-00-106", "Invalid relationship 
label {0}. The referenced entity type {1} could not be resolved from the type 
registry."),
+    NON_INDEXABLE_BM_DELETE_NOT_ALLOWED(400, "ATLAS-400-00-107", "Deletion not 
allowed for non-indexable Business Metadata ''{0}'' without force=true. 
Non-indexable attributes cannot be validated efficiently for references; use 
force=true to skip validation and delete (warning: orphaned references may 
remain)."),

Review Comment:
   With force=true, Atlas deletes the typedef without checking whether entities 
still hold values for those attributes, such values may remain on entity 
instances until separately cleaned up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to