Brijesh619 commented on code in PR #697:
URL: https://github.com/apache/atlas/pull/697#discussion_r3688766698
##########
dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx:
##########
Review Comment:
Added a fallback check for guid from useParams() to ensure it is always
passed as a string, fixing the TypeScript strictness failure.
##########
dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx:
##########
@@ -303,27 +312,33 @@ const UserDefinedProperties = ({ loading,
customAttributes, entity }: any) => {
})
) : (
<span>
- No properties have been created yet. To add a
- property,click{" "}
- <Typography
- className="text-color-green cursor-pointer"
- component="span"
- onClick={(e: { stopPropagation: () => void }) => {
- e.stopPropagation();
- setAddLabel(false);
- }}
- style={{ textDecoration: "underline" }}
- >
- here
- </Typography>
+ {entity?.status === EntityStatus.DELETED ? (
+ "No properties have been created yet."
+ ) : (
+ <>
+ No properties have been created yet. To add a
+ property,click{" "}
+ <Typography
+ className="text-color-green cursor-pointer"
+ component="span"
+ onClick={(e: { stopPropagation: () => void }) =>
{
+ e.stopPropagation();
+ setAddLabel(false);
+ }}
+ className="text-color-green cursor-pointer
text-underline"
Review Comment:
Removed the duplicate className attributes on Typography elements and merged
their styles into a single attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
