Brijesh619 commented on code in PR #697:
URL: https://github.com/apache/atlas/pull/697#discussion_r3774943987
##########
dashboard/src/views/DetailPage/EntityDetailTabs/ClassificationsTab.tsx:
##########
@@ -42,6 +42,7 @@ import DeleteOutlinedIcon from
"@mui/icons-material/DeleteOutlined";
import { isEntityPurged } from "@utils/Enum";
import CustomModal from "@components/Modal";
import ErrorRoundedIcon from "@mui/icons-material/ErrorRounded";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Added a test in ClassificationsTab.test.tsx to verify that the Edit and
Delete action buttons are not rendered when the parent entity has a DELETED
status.
##########
dashboard/src/views/DetailPage/EntityDetailPage.tsx:
##########
@@ -39,6 +39,7 @@ import { fetchDetailPageData } from
"@redux/slice/detailPageSlice";
import { normalizeSchemaElementsAttribute } from
"@utils/schemaElementsAttributeUtils";
import { SchemaTabCacheState } from "@models/schemaTabTypes";
import React from "react";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Added a test case in EntityDetailPage.test.tsx to verify that the 'Add
Classification' and 'Add Term' buttons are not rendered when the entity.status
=== 'DELETED'
##########
dashboard/src/views/DetailPage/DetailPageAttributes.tsx:
##########
@@ -41,6 +41,7 @@ const getDescriptionForDisplay = (desc: unknown): string => {
};
import { useState } from "react";
import { useAppSelector } from "@hooks/reducerHook";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Added negative tests in DetailPageAttributes.test.tsx to verify that 'Add
Classifications', 'Add Term', and 'Add Categories' buttons are hidden for
DELETED entities. Also fixed DetailPageAttributes.tsx to ensure the DELETED
guard is correctly applied to the 'Add Categories' and 'Add Attributes' buttons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
