Brijesh619 commented on code in PR #697:
URL: https://github.com/apache/atlas/pull/697#discussion_r3774945683
##########
dashboard/src/views/DetailPage/EntityDetailTabs/AttributeProperties.tsx:
##########
@@ -202,7 +203,7 @@ const AttributeProperties = ({
inputProps={{ "aria-label": "controlled" }}
/>
</LightTooltip>
- {entityUpdate && (
+ {entityUpdate && !loading && entity?.status !==
EntityStatus.DELETED && (
Review Comment:
Added a test in AttributeProperties.test.tsx to ensure the 'Edit' button is
correctly hidden for DELETED entities
##########
dashboard/src/components/ShowMore/DrawerBodyChipView.tsx:
##########
@@ -37,6 +37,7 @@ import SearchIcon from "@mui/icons-material/Search";
import ErrorRoundedIcon from "@mui/icons-material/ErrorRounded";
import { Link as MuiLink } from "@mui/material";
import { cloneDeep } from "@utils/Helper";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Added a test in DrawerBodyChipView.test.tsx to verify that the delete icon
is not rendered (i.e. onDelete is undefined) when currentEntity.status ===
'DELETED'
##########
dashboard/src/components/__tests__/EntityDisplayImage.test.tsx:
##########
@@ -29,6 +29,7 @@
import React from 'react'
import { render, waitFor, act } from '@testing-library/react'
import DisplayImage from '../EntityDisplayImage'
Review Comment:
Added negative tests in BMAttributes.test.tsx, Labels.test.tsx, and
UserDefinedProperties.test.tsx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
