Brijesh619 commented on code in PR #697: URL: https://github.com/apache/atlas/pull/697#discussion_r3782952255
########## dashboard/src/utils/EntityStatus.ts: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +export enum EntityStatus { + ACTIVE = "ACTIVE", + DELETED = "DELETED", + PURGED = "PURGED" +} + +export const isEntityModificationAllowed = (status: EntityStatus | string | undefined): boolean => { Review Comment: Resolved. Replaced all manual EntityStatus.DELETED checks with the isEntityModificationAllowed helper across the application to properly guard against both DELETED and PURGED states. ########## dashboard/src/components/__tests__/EntityDisplayImage.test.tsx: ########## @@ -29,6 +29,7 @@ import React from 'react' Review Comment: Resolved. Added matching PURGED negative test cases across all Properties tab test files to ensure Add/Edit actions remain fully blocked for purged entities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
