----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53316/#review155226 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (line 56) <https://reviews.apache.org/r/53316/#comment225067> Instead of having all entities include 'transientId' attribute, how about treating guid values that start with "-" as transient? It will keep the structure of AtlasEntity cleaner. intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java (line 34) <https://reviews.apache.org/r/53316/#comment225069> Please review if changes in this file are necessary. If not needed, consider reverting this file. intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 40) <https://reviews.apache.org/r/53316/#comment225070> Please review if changes in this file are necessary. If not needed, consider reverting this file. repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java (line 72) <https://reviews.apache.org/r/53316/#comment225072> This is duplicate of line #77. Please review and remove. If no changes are needed in this file, consider reverting this file. webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 56) <https://reviews.apache.org/r/53316/#comment225080> This implementation seems similar to AtlasArrayType.getNormalizedValue(Object obj) - which handles List/Set/built-in array value. Please review if it helps to handle built-in array. webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java (line 47) <https://reviews.apache.org/r/53316/#comment225100> Consider returning "type.getNormalizedValue(source)" - which return correct primitive type (Boolean/Integer/Double/String), after necessary convertions - if necessary. webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java (line 87) <https://reviews.apache.org/r/53316/#comment225101> source would be null here. Perhaps this else was meant to be for the 'if' at line #73? webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java (line 113) <https://reviews.apache.org/r/53316/#comment225102> Consider taking AtlasStructType as parameter, instead of Collection<AtlasStructDef.AtlasAttributeDef>. AtlasStructType has a cache of AtlasType for each of its attribute - which can help eliminate typeRegistry.getType(attrTypeName) the need to instantiate AtlasArrayType and AtlasMapType (for array/map attributes). - Madhan Neethiraj On Nov. 4, 2016, 11:24 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53316/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 11:24 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1257 > https://issues.apache.org/jira/browse/ATLAS-1257 > > > Repository: atlas > > > Description > ------- > > EntitiesREST will talk to the ATLAS v1 backend by converting from > a. AtlasEntity to Referenceable > b. AtlasStruct to Struct > c. Map of complex types > d. Array of complex types > and call the V1 backend directly as a workaround before v2 implementation is > completely ready. > > > Diffs > ----- > > distro/src/bin/atlas_stop.py a2b1c31 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27 > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > 5921fea > intg/src/main/java/org/apache/atlas/model/instance/AtlasTransientId.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > cd44318 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 95c3dd9 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 2351891 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityToReferenceableConverter.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > 0c2e0ec > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2 > > webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityToEntityConverterTest.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityValidators.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityvsReferenceValidator.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/adapters/AtlasInstanceValueValidation.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53316/diff/ > > > Testing > ------- > > Pending - UTS in progress > REST layer - tested create and update through the new APIs > > > Thanks, > > Suma Shivaprasad > >
