-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53316/
-----------------------------------------------------------

(Updated Nov. 10, 2016, 11:33 p.m.)


Review request for atlas.


Changes
-------

Fixed review comments


Bugs: ATLAS-1257
    https://issues.apache.org/jira/browse/ATLAS-1257


Repository: atlas


Description
-------

EntitiesREST will talk to the ATLAS v1 backend by converting from 
a. AtlasEntity to Referenceable 
b. AtlasStruct to Struct
c. Map of complex types
d. Array of complex types
and call the V1 backend directly as a workaround before v2 implementation is 
completely ready.


Diffs (updated)
-----

  distro/src/bin/atlas_stop.py a2b1c31 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea 
  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
a6c75ed 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b 
  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
69e8d12 
  
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
 37c2374 
  server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
2351891 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 
PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java 
PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 
0c2e0ec 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
bbf01a6 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java 
PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/53316/diff/


Testing
-------

Pending - UTS in progress
REST layer - tested create and update through the new APIs


Thanks,

Suma Shivaprasad

Reply via email to