----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53316/#review155758 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java (line 30) <https://reviews.apache.org/r/53316/#comment225843> 'registry' does not seem to be needed here. Please review and remove. webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java (line 57) <https://reviews.apache.org/r/53316/#comment225844> This comment does not look relevant here. Please review. webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java (line 59) <https://reviews.apache.org/r/53316/#comment225846> 'struct' could be null - AtlasStructToStructConverter.convert() returns null. Please review and add null checks. webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 177) <https://reviews.apache.org/r/53316/#comment225851> Please add a TODO here, so that it is easier to find pending work. webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 142) <https://reviews.apache.org/r/53316/#comment225850> Same path is used for getById() and getWithAssociationsByGuid() - "/guid/{guid}". Please update. getById() - "/guid/{guid}" getWithAssociationsByGuid() - "/guid/withAssociations/{guid}" webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 217) <https://reviews.apache.org/r/53316/#comment225849> Consider moving 'private' methods to end of the file. - Madhan Neethiraj On Nov. 12, 2016, 12:24 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53316/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2016, 12:24 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1257 > https://issues.apache.org/jira/browse/ATLAS-1257 > > > Repository: atlas > > > Description > ------- > > EntitiesREST will talk to the ATLAS v1 backend by converting from > a. AtlasEntity to Referenceable > b. AtlasStruct to Struct > c. Map of complex types > d. Array of complex types > and call the V1 backend directly as a workaround before v2 implementation is > completely ready. > > > Diffs > ----- > > distro/src/bin/atlas_stop.py a2b1c31 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba > intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java > b88d4e8 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27 > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > 5921fea > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > a6c75ed > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a53b11d > intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 69e8d12 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 37c2374 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 2351891 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > 0c2e0ec > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > bbf01a6 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2 > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java df5138e > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > PRE-CREATION > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53316/diff/ > > > Testing > ------- > > Added valid case UTs > REST layer - tested create and update through the new APIs > Have to add invalid case UTs > > > Thanks, > > Suma Shivaprasad > >
