[
https://issues.apache.org/jira/browse/AVRO-3236?focusedWorklogId=666764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666764
]
ASF GitHub Bot logged work on AVRO-3236:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 08:09
Start Date: 19/Oct/21 08:09
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on pull request #1375:
URL: https://github.com/apache/avro/pull/1375#issuecomment-946466458
Hey thanks so much! This looks like it fixes all of the Windows issues. I
gave it a clean build a try on a VM with Visual Studio 2019 installed:
```
Build started...
1>------ Build started: Project: Avro.main, Configuration: Debug Any CPU
------
1>Avro.main ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\main\bin\Debug\netstandard2.1\Avro.dll
2>------ Build started: Project: Avro.test, Configuration: Debug Any CPU
------
3>------ Build started: Project: Avro.codegen, Configuration: Debug Any CPU
------
3>Avro.codegen ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\codegen\bin\Debug\net5.0\avrogen.dll
3>Avro.codegen ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\codegen\bin\Debug\netcoreapp3.1\avrogen.dll
4>------ Build started: Project: Avro.msbuild, Configuration: Debug Any CPU
------
4>Avro.msbuild ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\msbuild\bin\Debug\net461\Avro.msbuild.dll
2>Avro.test ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\test\bin\Debug\netcoreapp3.1\Avro.test.dll
2>Avro.test ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\test\bin\Debug\net461\Avro.test.dll
2>Avro.test ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\test\bin\Debug\net5.0\Avro.test.dll
4>Avro.msbuild ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\msbuild\bin\Debug\netstandard2.0\Avro.msbuild.dll
5>------ Build started: Project: Avro.perf, Configuration: Debug Any CPU
------
5>Avro.perf ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\perf\bin\Debug\net461\Avro.perf.exe
5>Avro.perf ->
C:\Users\rskraba\Documents\avro\lang\csharp\src\apache\perf\bin\Debug\net5.0\Avro.perf.dll
========== Build: 5 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
```
As well as the command line build in Windows:
```
rskraba@VisualStudio MINGW64 ~/My Documents/avro/lang/csharp (avro__pr1375)
$ ./build.sh clean
++ dirname ./build.sh
+ cd .
+ ROOT=../..
++ cat ../../share/VERSION.txt
+ VERSION=1.12.0-SNAPSHOT
+ for target in "$@"
+ case "$target" in
+ rm -rf src/apache/main/obj src/apache/main/bin src/apache/test/obj
src/apache/test/bin src/apache/codegen/obj src/apache/codegen/bin
src/apache/ipc/obj src/apache/ipc/bin src/apache/msbuild/obj
src/apache/msbuild/bin src/apache/perf/obj src/apache/perf/bin
+ rm -rf build
+ rm -f TestResult.xml
rskraba@VisualStudio MINGW64 ~/My Documents/avro/lang/csharp (avro__pr1375)
$ ./build.sh test
++ dirname ./build.sh
+ cd .
+ ROOT=../..
++ cat ../../share/VERSION.txt
+ VERSION=1.12.0-SNAPSHOT
+ for target in "$@"
+ case "$target" in
+ dotnet build --configuration Release Avro.sln
Microsoft (R) Build Engine version 16.11.1+3e40a09f8 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
Determining projects to restore...
Restored C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\Avro.test.csproj (in 817 ms).
Restored C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\main\Avro.main.csproj (in 793 ms).
Restored C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\codegen\Avro.codegen.csproj (in 49 ms).
Restored C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\msbuild\Avro.msbuild.csproj (in 117 ms).
Restored C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\perf\Avro.perf.csproj (in 407 ms).
Avro.main -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\main\bin\Release\netstandard2.0\Avro.dll
Avro.main -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\main\bin\Release\netstandard2.1\Avro.dll
Avro.perf -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\perf\bin\Release\net5.0\Avro.perf.dll
Avro.test -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\bin\Release\netcoreapp3.1\Avro.test.dll
Avro.codegen -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\codegen\bin\Release\net5.0\avrogen.dll
Avro.test -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\bin\Release\net5.0\Avro.test.dll
Avro.codegen -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\codegen\bin\Release\netcoreapp3.1\avrogen.dll
Avro.perf -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\perf\bin\Release\net461\Avro.perf.exe
Avro.msbuild -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\msbuild\bin\Release\netstandard2.0\Avro.msbuild.dll
Avro.msbuild -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\msbuild\bin\Release\net461\Avro.msbuild.dll
Avro.test -> C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\bin\Release\net461\Avro.test.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:37.47
+ LANG=en_US.UTF-8
+ dotnet test --configuration Release --no-build --filter
'TestCategory!=Interop' Avro.sln
Test run for C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\bin\Release\net461\Avro.test.dll
(.NETFramework,Version=v4.6.1)
Microsoft (R) Test Execution Command Line Tool Version 16.11.0
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Passed! - Failed: 0, Passed: 624, Skipped: 0, Total: 624,
Duration: 5 s - Avro.test.dll (net461)
Test run for C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\bin\Release\netcoreapp3.1\Avro.test.dll
(.NETCoreApp,Version=v3.1)
Microsoft (R) Test Execution Command Line Tool Version 16.11.0
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Passed! - Failed: 0, Passed: 618, Skipped: 0, Total: 618,
Duration: 1 s - Avro.test.dll (netcoreapp3.1)
Test run for C:\Users\rskraba\My
Documents\avro\lang\csharp\src\apache\test\bin\Release\net5.0\Avro.test.dll
(.NETCoreApp,Version=v5.0)
Microsoft (R) Test Execution Command Line Tool Version 16.11.0
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Passed! - Failed: 0, Passed: 617, Skipped: 0, Total: 617,
Duration: 1 s - Avro.test.dll (net5.0)
```
This LGTM -- I'm giving a full build with
https://github.com/apache/avro/pull/1357 a try -- @zcsizmadia can you give an
opinion on that PR? If we can merge both, we can probably do a 1.11.0 RC2 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 666764)
Time Spent: 20m (was: 10m)
> Retire .NET Core 2.1
> --------------------
>
> Key: AVRO-3236
> URL: https://issues.apache.org/jira/browse/AVRO-3236
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Zoltan Csizmadia
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> .NET Core was retired and EOL since August, 2021.
> [https://dotnet.microsoft.com/download/dotnet/2.1]
>
> # Remove netcoreapp2.1 from TargetFramework(s) in all csproj.
> # Remove .NET Core 2.1 dependency form the build environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
