[
https://issues.apache.org/jira/browse/AVRO-3236?focusedWorklogId=667029&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667029
]
ASF GitHub Bot logged work on AVRO-3236:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 14:28
Start Date: 19/Oct/21 14:28
Worklog Time Spent: 10m
Work Description: zcsizmadia edited a comment on pull request #1375:
URL: https://github.com/apache/avro/pull/1375#issuecomment-946781301
@RyanSkraba I added a target frameworks table to the lang/csharp/README.MD.
It reflects the current build state.
I have some proposals to do to cleanup the target frameworks and make it
more clear:
### Issues:
1. If netstandard2.0 is a target, no need to add net462, sonce .NET FW
4.6.1+ supports using .NET STandard libraries
2. I dont think there is a need for .NET FW 4.0 support ay more
3. The csproj builds for different targets based on running on Windows or
Linux
4. Many of the projects support different (maybe legacy) frameworks, e.g.
ipc, ipc.test
### Proposal:
1. Add the following to common.props (root of all csharp projects):
```
<PropertyGroup Label="Target Frameworks">
<!-- Exe -->
<DefaultExeTargetFrameworks>netcoreapp3.1;net5.0</DefaultExeTargetFrameworks>
<!-- Library -->
<DefaultLibraryTargetFrameworks>netstandard2.0;netstandard2.1</DefaultLibraryTargetFrameworks>
<!-- Unit Tests -->
<DefaultUnitTestsTargetFrameworks>$(DefaultExeTargetFrameworks)</DefaultUnitTestsTargetFrameworks>
</PropertyGroup>
```
2. Use the following for Exe projects:
```
<TargetFrameworks>$(DefaultExeTargetFrameworks)</TargetFrameworks>
```
3. Use the following for Library projects:
```
<TargetFrameworks>$(DefaultLibraryTargetFrameworks)</TargetFrameworks>
```
4. Use the following for Unit Tests projects:
```
<TargetFrameworks>$(DefaultLibraryTargetFrameworks)</TargetFrameworks>
```
5. No Condition for Windows check is needed any more
### Pros
1. The projects builds are very uniform across Linux and Windows
2. New Target framework (e.g. the upcoming net6.0) is easy to add, just
simple editing common.props
### Cons
.NET Framework 4.6+ will be supported (via .NET STandard 2.0), which in my
opinion is acceptable in 2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 667029)
Time Spent: 40m (was: 0.5h)
> Retire .NET Core 2.1
> --------------------
>
> Key: AVRO-3236
> URL: https://issues.apache.org/jira/browse/AVRO-3236
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Zoltan Csizmadia
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> .NET Core was retired and EOL since August, 2021.
> [https://dotnet.microsoft.com/download/dotnet/2.1]
>
> # Remove netcoreapp2.1 from TargetFramework(s) in all csproj.
> # Remove .NET Core 2.1 dependency form the build environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
