Agree: I created https://issues.apache.org/jira/browse/BEAM-2647 about that.

Regards
JB

On 07/20/2017 02:32 PM, Aviem Zur wrote:
Thanks Kenn for the info,
+1 that this should be included in a release verification guide.

On Thu, Jul 20, 2017 at 2:07 PM Jean-Baptiste Onofré <[email protected]>
wrote:

Hi Aljoscha

Do you have all python requirements installed on your machine ?

Especially, pip, setuptools, tox, ... ?

It sounds like a missing Python requirement on your machine to me.

Regards
JB

On 07/20/2017 10:36 AM, Aljoscha Krettek wrote:
+ 0.8

I tried running "mvn package” on my machine build it fails. This is the
log output:
https://gist.github.com/aljoscha/dc194303bede8bc635e2d8b691bb58f8 <
https://gist.github.com/aljoscha/dc194303bede8bc635e2d8b691bb58f8>. It
fails when trying to build the Python part. Unfortunately I know almost
nothing about this but one thing that caught my attention was this snipped
"RuntimeError: Not in apache git tree; unable to find proto definitions.”.
Could this be a problem?

Otherwise I’d say the RC is good and I did this:

   - verified the checksums and signature
   - checked that LICENSE and NOTICE are present
   - used the staged artefacts to create a Quickstart project
   - checked that the compiled Quickstart works with a Flink 1.2.1
cluster in batch and streaming mode

On 19. Jul 2017, at 19:48, Kenneth Knowles <[email protected]>
wrote:

+1 to the RC

Relating to Aviem's question, I think we need a release verification
guide,
at the least as a section of the Release Guide. But if we follow
through on
the prior thread of having a validation matrix with manual steps people
sign up for, that is even better, and saves repeated work.

As notes towards this, below this email I have included the steps to go
through the Java quickstart with the RC on DirectRunner and
DataflowRunner,
which I have done. It should be also easy for other runners.

I think the full ValidatesRunner suite run against the release-2.1.0
branch
is adequate rather than trying to run them all against the RC, since we
are
not trying (necessarily) to testing the release plugin. I wouldn't
_oppose_
an easy way to run the full suite... (maybe just a fancy command line?)

Kenn


<settings>
   <activeProfiles>
     <activeProfile>beam-2.1.0</activeProfile>
   </activeProfiles>
   <profiles>
     <profile>
       <id>beam-2.1.0</id>
       <repositories>
         <repository>
           <id>beam-2.1.0</id>
           <url>
https://repository.apache.org/content/repositories/orgapachebeam-1019/
</url>
         </repository>
         <repository>
           <id>archetype</id>
           <url>
https://repository.apache.org/content/repositories/orgapachebeam-1019/
</url>
         </repository>
       </repositories>
     </profile>
   </profiles>
</settings>

mvn archetype:generate \
       --settings settings.xml \
       -P beam-2.1.0 \
       -D archetypeGroupId=org.apache.beam \
       -D archetypeArtifactId=beam-sdks-java-maven-archetypes-examples \
       -D archetypeVersion=2.1.0 \
       -D groupId=org.example \
       -D artifactId=wordcountbeam \
       -D version="0.1" \
       -D package=org.apache.beam.examples \
       -D interactiveMode=false

cd wordcountbeam

mvn compile exec:java \
     --settings ../settings.xml \
     -Pdirect-runner \
     -D exec.mainClass=org.apache.beam.examples.WordCount \
     -D exec.args="--inputFile=pom.xml --output=counts"


mvn compile exec:java \
     --settings ../settings.xml \
     -P dataflow-runner \
     -D exec.mainClass=org.apache.beam.examples.WordCount \
     -D exec.args="--runner=DataflowRunner --project=<your-gcp-project>
--gcpTempLocation=gs://<your-gcs-bucket>/tmp
--inputFile=gs://apache-beam-samples/shakespeare/*
--output=gs://<your-gcs-bucket>/counts"

On Wed, Jul 19, 2017 at 10:19 AM, Jean-Baptiste Onofré <[email protected]

wrote:

I don't understand as all jars are on the Nexus staging repository.
The zip are also on staging repository.

Regards
JB

On Jul 19, 2017, 18:47, at 18:47, Aviem Zur <[email protected]>
wrote:
@JB

Hi, yes I saw that link, however those appear to be just the sources,
not
jars.
Do we have built RC jars us to validate which are then deployed as is
to
dist (renamed to remove -RC and so forth) or do we each compile these
manually and are assured that the sources in the dist are the actual
ones
that the final jars will be built from?

On Wed, Jul 19, 2017 at 7:16 PM Ahmet Altay <[email protected]

wrote:

Yes, +1 on RC2.

On Wed, Jul 19, 2017 at 5:10 AM, Jean-Baptiste Onofré
<[email protected]>
wrote:

Hi Aviem,

as mentioned in the first e-mail:

- Distributions are available here:
https://dist.apache.org/repos/dist/dev/beam/2.1.0/

- Artifacts are on the staging repository:


https://repository.apache.org/content/repositories/orgapachebeam-1019/

Regards
JB


On 07/19/2017 12:26 PM, Aviem Zur wrote:

Have the jars for RC2 been uploaded somewhere?

On Wed, Jul 19, 2017 at 10:19 AM Jean-Baptiste Onofré
<[email protected]>
wrote:

So, I guess you are voting +1 on RC2, correct (just for the
tracking) ?

Thanks,
Regards
JB

On 07/19/2017 08:00 AM, Ahmet Altay wrote:

Thank you JB.

I validated python wordcount and mobile gaming examples on
Linux.
Found

one

issue (https://issues.apache.org/jira/browse/BEAM-2636). This
does
not

need

to be a blocking issue for RC2, but if we end up having a RC3 we
should
consider fixing this issue.

Ahmet

On Tue, Jul 18, 2017 at 4:18 PM, Mingmin Xu <[email protected]>
wrote:

Thanks Kenn. SQL DSL should be ready in the next version 2.2.0,
and

agree

to have an overall row "Add SQL DSL" instead of listing all the
detailed
tasks.

On Tue, Jul 18, 2017 at 3:54 PM, Kenneth Knowles
<[email protected]


wrote:

Done.

Since it is all on a feature branch and the release notes when
it
goes

to

master will include "Add SQL DSL" I did not associate the little
bits

with

a release.

On Tue, Jul 18, 2017 at 2:51 PM, Mingmin Xu
<[email protected]>

wrote:


The tasks of SQL should not be labeled as 2.1.0, I've updated
some

with

2.2.0, fail to change the 'closed' ones. Can anyone with the

permission

update these tasks
https://issues.apache.org/jira/browse/BEAM-2171?jql=
project%20%3D%20BEAM%20AND%20fixVersion%20%3D%202.1.0%
20AND%20component%20%3D%20dsl-sql?


Thanks!
Mingmin

On Tue, Jul 18, 2017 at 2:23 PM, Jean-Baptiste Onofré <

[email protected]


wrote:

Yeah, indeed, the issue like BEAM-2171 should not have "Fix
Version"

set

to 2.1.0.

Regards
JB

On 07/18/2017 06:52 PM, James wrote:

Just noticed that some of the DSL_SQL issues are included in
this

release?

e.g. The first one: BEAM-2171, this is not expected,right?
On Wed, 19 Jul 2017 at 12:30 AM Jean-Baptiste Onofré <

[email protected]


wrote:

Hi everyone,


Please review and vote on the release candidate #2 for the
version

2.1.0,

as
follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide
specific

comments)



The complete staging area is available for your review,
which

includes:

* JIRA release notes [1],
* the official Apache source release to be deployed to

dist.apache.org

[2],
which is signed with the key with fingerprint C8282E76
[3],
* all artifacts to be deployed to the Maven Central
Repository
[4],
* source code tag "v2.1.0-RC2" [5],
* website pull request listing the release and publishing
the
API
reference
manual [6].
* Python artifacts are deployed along with the source
release to

the

dist.apache.org [2].

The vote will be open for at least 72 hours. It is adopted
by

majority

approval,
with at least 3 PMC affirmative votes.

Thanks,
JB

[1]


https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
ctId=12319527&version=12340528
[2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
[3] https://dist.apache.org/repos/dist/release/beam/KEYS
[4]
https://repository.apache.org/content/repositories/orgapache
beam-1019/
[5] https://github.com/apache/beam/tree/v2.1.0-RC2
[6] https://github.com/apache/beam-site/pull/270



--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com




--
----
Mingmin





--
----
Mingmin



--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com



--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com






--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com



--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com

Reply via email to