Thanks Ismael. I've marked these two issues for fix in 2.2.0. Definitely agree that at least the first one must be fixed.
Here's the current burndown list https://issues.apache.org/jira/projects/BEAM/versions/12341044 - we should clean it up. On Wed, Aug 30, 2017 at 1:20 PM Ismaël Mejía <ieme...@gmail.com> wrote: > The current master has accumulated a good amount of nice features > since 2.1.0 so a new release is welcomed. I have two JIRAs/PR that I > think are important to check/solve before the cut: > > BEAM-2516 (this is a regression on the performance of Direct runner on > Java). We had never really defined if a performance regression is > critical to be a blocker. I executed WordCount with the kinglear.txt > (170KB) file in version 2.1.0 vs the current 2.2.0-SNAPSHOT and I > found that the execution time passed from 5s to 126s. So maybe we need > to review this one before the release. I can understand if others > consider this a minor issue because the Direct runner is not supposed > to be used for production, but this performance regression can cause a > bad impression for a casual user starting with Beam. > > BEAM-2790 (fix reading from Amazon S3 via HadoopFileSystem). I think > this one is a nice to have. I am not sure that I can tackle it for the > wednesday cut. I’m OOO until the beginning of next week, but maybe > someone else can take a look. In the worst case this is not a release > blocker but definitely a really nice fix to include. > > > On Wed, Aug 30, 2017 at 8:49 PM, Eugene Kirpichov > <kirpic...@google.com.invalid> wrote: > > I'd like to get the following PRs into 2.2.0: > > > > #3765 <https://github.com/apache/beam/pull/3765> [BEAM-2753 > > <https://issues.apache.org/jira/browse/BEAM-2753>] Fixes translation of > > WriteFiles side inputs (important bugfix for DynamicDestinations in > files) > > #3725 <https://github.com/apache/beam/pull/3725> [BEAM-2827 > > <https://issues.apache.org/jira/browse/BEAM-2827>] Introduces > > AvroIO.watchForNewFiles (parity for AvroIO with TextIO in a few important > > features) > > #3759 <https://github.com/apache/beam/pull/3759> [BEAM-2828 > > <https://issues.apache.org/jira/browse/BEAM-2828>] Moves Match into > > FileIO.match()/matchAll() (to prevent releasing current > > Match.filepatterns() into 2.2.0 and then having to keep it under that > name) > > > > On Wed, Aug 30, 2017 at 11:31 AM Mingmin Xu <mingm...@gmail.com> wrote: > > > >> Glad to see that 2.2.0 is coming. Can we include SQL feature in next > >> release? We're in the final stage and expect to merge back to master > this > >> week. > >> > >> On Wed, Aug 30, 2017 at 11:27 AM, Reuven Lax <re...@google.com.invalid> > >> wrote: > >> > >> > Now that Beam 2.1.0 has finally completed, I think we should cut Beam > >> 2.2.0 > >> > soon. I volunteer to coordinate this release. > >> > > >> > Are there any pending pull requests that people think should be merged > >> > before we cut 2.2.0? If so, please let me know soon, as I would like > to > >> cut > >> > by Wednesday of next week. > >> > > >> > Thanks, > >> > > >> > Reuven > >> > > >> > >> > >> > >> -- > >> ---- > >> Mingmin > >> >
