+1
Le 16 juil. 2018 à 19:17, à 19:17, Holden Karau <holden.ka...@gmail.com> a écrit: ><div dir="auto"> >Ok if no one objects I'll create the INFRA ticket after OSCON and we >can test it for a week and decide if it helps or hinders. ></div> ><br> ><div class="gmail_quote"> > <div dir="ltr" class="type_quote"> > On Mon, Jul 16, 2018, 7:12 PM Jean-Baptiste Onofré < > <a href="mailto:j...@nanthrax.net";>j...@nanthrax.net</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div> > <div dir="auto"> > Agree to test it for a week. > <br> > <br> > </div> > <div dir="auto"> > Regards > <br> > </div> > <div dir="auto"> > JB > </div> > <div class="gmail_quote"> > Le 16 juil. 2018, à 18:59, Holden Karau < ><a href="mailto:holden.ka...@gmail.com"; target="_blank" >rel="noreferrer">holden.ka...@gmail.com</a>> a écrit: ><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt >0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > <div dir="auto"> > <div> >Would folks be OK with me asking infra to turn on blame based >suggestions for Beam and trying it out for a week? > <br> > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Mon, Jul 16, 2018, 6:53 PM Rafael Fernandez < ><a href="mailto:rfern...@google.com"; target="_blank" >rel="noreferrer">rfern...@google.com</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> ><div class="gmail_default" >style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"> > +1 using blame -- nifty :) > <br> > </div> > </div> > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Mon, Jul 16, 2018 at 2:31 AM Huygaa Batsaikhan < ><a href="mailto:bat...@google.com"; rel="noreferrer noreferrer" >target="_blank">bat...@google.com</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> > +1. This is great. > <br> > </div> > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Sat, Jul 14, 2018 at 7:44 AM Udi Meiri < ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> >Mention bot looks cool, as it tries to guess the reviewer using blame. > <div> > I've written a quick and dirty script that uses only CODEOWNERS. > </div> > <div> > <br> > </div> > <div> > Its output looks like: > </div> > <div> > <div> > $ python suggest_reviewers.py --pr 5940 > </div> > <div> >INFO:root:Selected reviewer @lukecwik for: >/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformMatchers.java >(path_pattern: /runners/core-construction-java*) > </div> > <div> >INFO:root:Selected reviewer @lukecwik for: >/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDoNaiveBounded.java >(path_pattern: /runners/core-construction-java*) > </div> > <div> >INFO:root:Selected reviewer @echauchot for: >/runners/core-java/src/main/java/org/apache/beam/runners/core/SplittableParDoViaKeyedWorkItems.java >(path_pattern: /runners/core-java*) > </div> > <div> >INFO:root:Selected reviewer @lukecwik for: /runners/flink/build.gradle >(path_pattern: */build.gradle*) > </div> > <div> >INFO:root:Selected reviewer @lukecwik for: >/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkTransformOverrides.java >(path_pattern: *.java) > </div> > <div> >INFO:root:Selected reviewer @pabloem for: >/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java >(path_pattern: /runners/google-cloud-dataflow-java*) > </div> > <div> >INFO:root:Selected reviewer @lukecwik for: >/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java >(path_pattern: /sdks/java/core*) > </div> > <div> > Suggested reviewers: @echauchot, @lukecwik, @pabloem > </div> > </div> > <div> > <br> > </div> > <div> > Script is in: ><a href="https://github.com/apache/beam/pull/5951"; rel="noreferrer >noreferrer" >target="_blank">https://github.com/apache/beam/pull/5951</a> > <br> > </div> > <div> > <br> > </div> > <div> > <br> > </div> > <div> >What does the community think? Do you prefer blame-based or rules-based >reviewer suggestions? > </div> > </div> > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Fri, Jul 13, 2018 at 11:13 AM Holden Karau < ><a href="mailto:hol...@pigscanfly.ca"; rel="noreferrer noreferrer" >target="_blank">hol...@pigscanfly.ca</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> >I'm looking at something similar in the Spark project, and while it's >now archived by FB it seems like something like ><a href="https://github.com/facebookarchive/mention-bot"; >rel="noreferrer noreferrer" >target="_blank">https://github.com/facebookarchive/mention-bot</a> >might do what we want. I'm going to spin up a version on my K8 cluster >and see if I can ask infra to add a webhook and if it works for Spark >we could ask INFRA to add a second webhook for Beam. (Or if the Beam >folks are more interested in experimenting I can do Beam first as a >smaller project and roll with that). > <div> > <br> > </div> > <div> > Let me know :) > </div> > </div> > <div class="gmail_extra"> > <br> > <div class="gmail_quote"> > On Fri, Jul 13, 2018 at 10:53 AM, Eugene Kirpichov ><span dir="ltr"><<a href="mailto:kirpic...@google.com"; >rel="noreferrer noreferrer" >target="_blank">kirpic...@google.com</a>></span> wrote: > <br> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> > Sounds reasonable for now, thanks! > <div> >It's unfortunate that Github's CODEOWNERS feature appears to be >effectively unusable for Beam but I'd hope that Github might pay >attention and fix things if we submit feedback, with us being one of >the most active Apache projects - did anyone do this yet / planning to? > > </div> > </div> ><div >class="m_-478435520910394914m_7396806346302700623m_-7703830691123338455m_-1618044592392902469m_-5666860863733626073m_-4086401482094477601HOEnZb"> > ><div >class="m_-478435520910394914m_7396806346302700623m_-7703830691123338455m_-1618044592392902469m_-5666860863733626073m_-4086401482094477601h5"> > > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Fri, Jul 13, 2018 at 10:23 AM Udi Meiri < ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> >While I like the idea of having a CODEOWNERS file, the Github >implementation is lacking: > <div> > 1. Reviewers are automatically assigned at each push. > <br> > </div> > <div> >2. Reviewer assignment can be excessive (e.g. 5 reviewers in Eugene's >PR 5940). > </div> > <div> > 3. Non-committers aren't assigned as reviewers. > </div> > <div> > 4. Non-committers can't change the list of reviewers. > </div> > <div> > <br> > </div> > <div> >I propose renaming the file to disable the auto-reviewer assignment >feature. > </div> > <div> > In its place I'll add a script that suggests reviewers. > </div> > </div> > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Fri, Jul 13, 2018 at 9:09 AM Udi Meiri < ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > <div dir="ltr"> > Hi Etienne, > <div> > <br> > </div> > <div> >Yes you could be as precise as you want. The paths I listed are just >suggestions. :) > <div> > <br> > </div> > </div> > </div> > <br> > <div class="gmail_quote"> > <div dir="ltr"> > On Fri, Jul 13, 2018 at 1:12 AM Jean-Baptiste Onofré < ><a href="mailto:j...@nanthrax.net"; rel="noreferrer noreferrer" >target="_blank">j...@nanthrax.net</a>> wrote: > <br> > </div> ><blockquote class="gmail_quote" style="margin:0 0 0 >.8ex;border-left:1px #ccc solid;padding-left:1ex"> > Hi, > <br> > <br> I think it's already do-able just providing the expected path. > <br> > <br> It's a good idea especially for the core. > <br> > <br> Regards > <br> JB > <br> > <br> On 13/07/2018 09:51, Etienne Chauchot wrote: > <br> > Hi Udi, > <br> > ><br> > I also have a question, related to what Eugene asked : I see >that the ><br> > code paths are the ones of the modules. Can we be more >precise than that ><br> > to assign reviewers ? As an example, I added myself to >runner/core > <br> > because I wanted to take a look at the PRs related to ><br> > runner/core/metrics but I'm getting assigned to all >runner-core PRs. Can > <br> > we specify paths like ><br> > >runners/core-java/src/main/java/org/apache/beam/runners/core/metrics ? ><br> > I know it is a bit too precise so a bit risky, but in that >particular > <br> > case, I doubt that the path will change. > <br> > > <br> > Etienne > <br> > ><br> > Le jeudi 12 juillet 2018 à 16:49 -0700, Eugene Kirpichov a >écrit : > <br> >> Hi Udi, > <br> >> ><br> >> I see that the PR was merged - thanks! However it seems >to have some > <br> >> unintended effects. > <br> >> > <br> >> On my PR ><a href="https://github.com/apache/beam/pull/5940"; rel="noreferrer >noreferrer noreferrer" >target="_blank">https://github.com/apache/beam/pull/5940</a> , I >assigned a ><br> >> reviewer manually, but the moment I pushed a new commit, >it ><br> >> auto-assigned a lot of other people to it, and I had to >remove them. ><br> >> This seems like a big inconvenience to me, is there a way >to disable this? > <br> >> > <br> >> Thanks. > <br> >> > <br> >> On Thu, Jul 12, 2018 at 2:53 PM Udi Meiri < ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a> > <br> >> <mailto: ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a>>> wrote: > <br> >>> :/ That makes it a little less useful. > <br> >>> > <br> >>> On Thu, Jul 12, 2018 at 11:14 AM Tim Robertson > <br> >>> < ><a href="mailto:timrobertson...@gmail.com"; rel="noreferrer noreferrer" >target="_blank">timrobertson...@gmail.com</a> <mailto: ><a href="mailto:timrobertson...@gmail.com"; rel="noreferrer noreferrer" >target="_blank">timrobertson...@gmail.com</a>>> wrote: > <br> >>>> Hi Udi > <br> >>>> ><br> >>>> I asked the GH helpdesk and they confirmed that >only people with ><br> >>>> write access will actually be automatically >chosen. > <br> >>>> ><br> >>>> It don't expect it should stop us using it, but >we should be aware ><br> >>>> that there are non-committers also willing to >review. > <br> >>>> > <br> >>>> Thanks, > <br> >>>> Tim > <br> >>>> ><br> >>>> On Thu, Jul 12, 2018 at 7:24 PM, Mikhail >Gryzykhin > <br> >>>> < ><a href="mailto:mig...@google.com"; rel="noreferrer noreferrer" >target="_blank">mig...@google.com</a> <mailto: ><a href="mailto:mig...@google.com"; rel="noreferrer noreferrer" >target="_blank">mig...@google.com</a>>> wrote: > <br> >>>>> Idea looks good in general. > <br> >>>>> ><br> >>>>> Did you look into ways to keep this file >up-to-date? For example we ><br> >>>>> can run monthly job to see if owner was >active during this period. > <br> >>>>> > <br> >>>>> --Mikhail > <br> >>>>> > <br> >>>>> Have feedback < ><a href="http://go/migryz-feedback"; rel="noreferrer noreferrer >noreferrer" target="_blank">http://go/migryz-feedback</a>>? > <br> >>>>> > <br> >>>>> ><br> >>>>> On Thu, Jul 12, 2018 at 9:56 AM Udi Meiri >< ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a> > <br> >>>>> <mailto: ><a href="mailto:eh...@google.com"; rel="noreferrer noreferrer" >target="_blank">eh...@google.com</a>>> wrote: > <br> >>>>>> Thanks all! ><br> >>>>>> I'll try to get the file merged today and >see how it works out. ><br> >>>>>> Please surface any issues, such as with >auto-assignment, here or > <br> >>>>>> in JIRA. > <br> >>>>>> ><br> >>>>>> On Thu, Jul 12, 2018 at 2:12 AM Etienne >Chauchot > <br> >>>>>> < ><a href="mailto:echauc...@apache.org"; rel="noreferrer noreferrer" >target="_blank">echauc...@apache.org</a> <mailto: ><a href="mailto:echauc...@apache.org"; rel="noreferrer noreferrer" >target="_blank">echauc...@apache.org</a>>> wrote: > <br> >>>>>>> Hi, > <br> >>>>>>> ><br> >>>>>>> I added myself as a reviewer for some >modules. > <br> >>>>>>> > <br> >>>>>>> Etienne > <br> >>>>>>> ><br> >>>>>>> Le lundi 09 juillet 2018 à 17:06 >-0700, Udi Meiri a écrit : > <br> >>>>>>>> Hi everyone, > <br> >>>>>>>> ><br> >>>>>>>> I'm proposing to add >auto-reviewer-assignment using Github's > <br> >>>>>>>> CODEOWNERS mechanism. > <br> >>>>>>>> Initial version is > <br> >>>>>>>> here: _ ><a href="https://github.com/apache/beam/pull/5909/files_"; >rel="noreferrer noreferrer noreferrer" >target="_blank">https://github.com/apache/beam/pull/5909/files_</a> > <br> >>>>>>>> ><br> >>>>>>>> I need help from the community in >determining owners for each > <br> >>>>>>>> component. ><br> >>>>>>>> Feel free to directly edit the PR >(if you have permission) or > <br> >>>>>>>> add a comment. > <br> >>>>>>>> > <br> >>>>>>>> > <br> >>>>>>>> Background > <br> >>>>>>>> The idea is to: ><br> >>>>>>>> 1. Document good review >candidates for each component. ><br> >>>>>>>> 2. Help choose reviewers using >the auto-assignment mechanism. ><br> >>>>>>>> The suggestion is in no way >binding. > <br> >>>>>>>> > <br> >>>>>>>> > <br> >>>> > <br> > <br> -- > <br> Jean-Baptiste Onofré > <br> ><a href="mailto:jbono...@apache.org"; rel="noreferrer noreferrer" >target="_blank">jbono...@apache.org</a> > <br> ><a href="http://blog.nanthrax.net"; rel="noreferrer noreferrer >noreferrer" target="_blank">http://blog.nanthrax.net</a> > <br> Talend - ><a href="http://www.talend.com"; rel="noreferrer noreferrer noreferrer" >target="_blank">http://www.talend.com</a> > <br> > </blockquote> > </div> > </blockquote> > </div> > </blockquote> > </div> > </div> > </div> > </blockquote> > </div> > <br> > <br clear="all"> > <div> > <br> > </div>-- > <br> ><div >class="m_-478435520910394914m_7396806346302700623m_-7703830691123338455m_-1618044592392902469m_-5666860863733626073m_-4086401482094477601gmail_signature" >data-smartmail="gmail_signature"> > <div dir="ltr"> > <div> > <div dir="ltr"> > <div dir="ltr"> > <div> > <span style="font-size:12.8px">Twitter: </span> ><a href="https://twitter.com/holdenkarau"; style="font-size:12.8px" >rel="noreferrer noreferrer" >target="_blank">https://twitter.com/holdenkarau</a> > <br> > </div> > </div> > </div> > </div> > </div> > </div> > </div> > </blockquote> > </div> > </blockquote> > </div> > </blockquote> > </div> > </blockquote> > </div> > </div> > </div> > </blockquote> > </div> > </div> > </blockquote> ></div>
