I guess I'm voting for 2. Tests obviously belong in the code repo, both as a sample usage (not "how-to", more like "man") and, well, for testing. These pipelines might not be annotated as completely and include hitting edge cases and other non-standard situations.
Any example where the primary purpose is external consumption seems totally reasonable to move out. Regardless of where they are stored, trying to share these artifacts explicitly seems less than ideal. The cost of duplication here seems low. On Wed, Aug 8, 2018 at 11:01 AM Rui Wang <ruw...@google.com> wrote: > 2 - examples that rely on experimental API can still stay in where they > are because such examples could be changed. > > -Rui > > On Wed, Aug 8, 2018 at 10:52 AM Charles Chen <c...@google.com> wrote: > >> 3 - We benefit from increased test coverage by having examples together >> with the rest of the code. As Robert mentions in the doc, hosting the Beam >> examples in the main repository is the best way to keep the examples >> visible, tested and maintained. Given that we recently moved to a single >> repository for the website since that previously caused a lot of pain, it >> makes sense to be consistent here. >> >> On Wed, Aug 8, 2018 at 10:27 AM Ahmet Altay <al...@google.com> wrote: >> >>> 2 - Similar to Huygaa, I see value in keeping a core set of examples >>> tested and maintained against head. At the same time I understand the value >>> of a growing set of community grown examples that are targeted against a >>> pre-defined versions of Beam and not necessarily updated at every release. >>> >>> On Wed, Aug 8, 2018 at 10:22 AM, Huygaa Batsaikhan <bat...@google.com> >>> wrote: >>> >>>> 2 - I like the idea of having a separate repo where we can have more >>>> freedom to check in examples. However, we benefit from having immediate >>>> core examples in Beam for testing purposes. >>>> >>>> On Wed, Aug 8, 2018 at 9:38 AM David Cavazos <dcava...@google.com> >>>> wrote: >>>> >>>>> Hi everyone! >>>>> >>>>> We discussed several options as well as some of the implications of >>>>> each option. Please vote for your favorite option, feel free to back it up >>>>> with any reasons that make you feel that way. >>>>> >>>>> 1) Move *all* samples to a *new *examples* repository* >>>>> 2) Move *some* samples to a *new *examples* repository* >>>>> 3) Leave samples where they are >>>>> >>>>> Some implications to creating a new repository: >>>>> - Every example would be independent from every other example, so >>>>> tests can be run in parallel >>>>> - Examples would now show how to use Beam *externally* >>>>> - The examples repository would need a testing infrastructure >>>>> - Decoupling makes examples easier to test on different versions >>>>> - Easier to copy-paste an existing example and start from there, >>>>> almost like a template >>>>> - Smaller size for the core Beam library >>>>> - Two different repositories to maintain >>>>> - Versioning could mirror Beam's current version >>>>> >>>>> Link to proposal >>>>> <https://docs.google.com/document/d/1vhcKJlP0qH1C7NZPDjohT2PUbOD-k71avv1CjEYapdw/edit?usp=sharing> >>>>> >>>> >>>
