I am having trouble reviewing the staged version. What is the best way to
review this change?

Do we expect any changes to markdown files, beyond some metadata?

On Tue, Apr 28, 2020 at 10:45 AM Robert Bradshaw <rober...@google.com>
wrote:

> Thanks. It'll be great to better support more languages.
>
> I looked at the PR and there seems to be no provenance/history. E.g. all
> the content seems to be entirely new files rather than diffs from the old.
> (There also seems to be a huge amount of auto-generated js code as well.)
>

I agree. This makes it very hard to review. I also see a bunch of deleted
markdown files. Are they not getting migrated?


>
> On Tue, Apr 28, 2020 at 10:23 AM Aizhamal Nurmamat kyzy <
> aizha...@apache.org> wrote:
>
>> Hello everybody,
>>
>> We are almost done migrating the Apache Beam website from Jekyll to Hugo.
>> You can see the PR in [1], and we'd love to hear your feedback/comments on
>> the PR. It includes  detailed guidelines on contributing to the new
>> Hugo-based website and adding translations to pages [2]. For those who are
>> curious about adding new languages, we will provide a proof of concept in
>> the next couple of days in this thread.
>>
>> Since we want to move forward with the PR, I would like to ask the
>> community to hold off changes to the current Beam website for a week, until
>> we are able to review and merge the PR. Is this acceptable to everyone?
>>
>> In case anyone missed my previous email with the background for the
>> website migration, you can find more context here [3].
>>
>> Thanks,
>> Aizhamal
>>
>> [1] https://github.com/apache/beam/pull/11554
>> [2]
>> https://github.com/apache/beam/blob/256b7042bf504b94f161ca03b388a2ba247918d9/website/CONTRIBUTE.md
>> [3]
>> https://lists.apache.org/thread.html/r7fa6d710c0a1959cce5108e460d71c306ce5756cf96af818b41cb7ca%40%3Cdev.beam.apache.org%3E
>>
>

Reply via email to