guyuqi commented on code in PR #1131:
URL: https://github.com/apache/bigtop/pull/1131#discussion_r1260487262
##########
bigtop-deploy/puppet/manifests/site.pp:
##########
@@ -24,8 +24,10 @@
node default {
$roles_enabled = hiera("bigtop::roles_enabled", false)
- if (!is_bool($roles_enabled)) {
- fail("bigtop::roles hiera conf is not of type boolean. It should be set to
either true or false")
+ if ($operatingsystem != 'openEuler') {
Review Comment:
You should confirm whether puppetlabs was properly installed or not when
deploying docker containers.
`is_bool` is the function of puppetlabs :
https://github.com/puppetlabs/puppetlabs-stdlib/blob/v8.6.0/lib/puppet/parser/functions/is_bool.rb.
If `puppetlabs` was installed correctly, `is_bool` was called appropriately
in puppet script `site.pp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
