MacChen01 commented on code in PR #1131:
URL: https://github.com/apache/bigtop/pull/1131#discussion_r1262065225
##########
bigtop-deploy/puppet/manifests/site.pp:
##########
@@ -24,8 +24,10 @@
node default {
$roles_enabled = hiera("bigtop::roles_enabled", false)
- if (!is_bool($roles_enabled)) {
- fail("bigtop::roles hiera conf is not of type boolean. It should be set to
either true or false")
+ if ($operatingsystem != 'openEuler') {
Review Comment:
> > #1132
>
> There are 2 options:
>
> 1. Create the Jira and link it to [install puppetlabs-stdlib 4.12.0 by
puppet in openeuler #1132](https://github.com/apache/bigtop/pull/1132) (add
Jira number to Pr title).
> 2. Or just add installation of puppetlabs-stdlib-4.12.0 into this PR.
ok, i add installation of puppetlabs-stdlib-4.12.0 into this PR:
commit: d006a324e422cef6217354fd0e99956a73f60ede
##########
bigtop-deploy/puppet/manifests/site.pp:
##########
@@ -24,8 +24,10 @@
node default {
$roles_enabled = hiera("bigtop::roles_enabled", false)
- if (!is_bool($roles_enabled)) {
- fail("bigtop::roles hiera conf is not of type boolean. It should be set to
either true or false")
+ if ($operatingsystem != 'openEuler') {
Review Comment:
> > #1132
>
> There are 2 options:
>
> 1. Create the Jira and link it to [install puppetlabs-stdlib 4.12.0 by
puppet in openeuler #1132](https://github.com/apache/bigtop/pull/1132) (add
Jira number to Pr title).
> 2. Or just add installation of puppetlabs-stdlib-4.12.0 into this PR.
ok, i add installation of puppetlabs-stdlib-4.12.0 into this PR:
commit: d006a324e422cef6217354fd0e99956a73f60ede
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
