guyuqi commented on code in PR #1131:
URL: https://github.com/apache/bigtop/pull/1131#discussion_r1262020736


##########
bigtop-deploy/puppet/manifests/site.pp:
##########
@@ -24,8 +24,10 @@
 node default {
   $roles_enabled = hiera("bigtop::roles_enabled", false)
 
-  if (!is_bool($roles_enabled)) {
-    fail("bigtop::roles hiera conf is not of type boolean. It should be set to 
either true or false")
+  if ($operatingsystem != 'openEuler') {

Review Comment:
   > #1132
   
   There are 2 options:
   1. Create the Jira and link it to #1132 (add Jira number to Pr title).
   2. Or just add installation of puppetlabs-stdlib-4.12.0 into this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to