On Mon, Feb 10, 2014 at 11:02 AM, Saint Germain <[email protected]> wrote:
> On 10 February 2014 16:48, Olemis Lang <[email protected]> wrote: > >> > In general I think the patches are in a good shape but the fact is > >> > that the current code for translations will also break the English > >> > version of the widget headers under certain circumstances ... > >> > > >> Do you mean the problem which is blocking is the "alert text rendered > >> outside container" ? > > > > No. I mean that the translation of widget titles (previosly explained > with > > fr+es) breaks the English site as well. > > > > Hum in that case I am a little lost: which problem are you referring > to specifically ? > see https://issues.apache.org/bloodhound/attachment/ticket/694/bh_widgets_x_150_i18n_titles.png I mean Spanish + French text , which also leads to translated + English text even if lang=en > (I may have misunderstood one of the previous problem, because I don't > see which one can break the english site if no translation is > available) > > no ... this obviously happens If translations are compiled into the corresponding catalog , but if translations are offered and they break the English web site then I'd consider that a regression and a blocker to release . Others might think in a different way , it's just IMO . -- Regards, Olemis - @olemislc
