sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129648828
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java ########## @@ -50,16 +55,21 @@ * @param featureProvider feature provider * @param statsLogger stats logger */ - public EnsemblePlacementPolicy initialize(ClientConfiguration conf, + public default EnsemblePlacementPolicy initialize(ClientConfiguration conf, Optional<DNSToSwitchMapping> optionalDnsResolver, HashedWheelTimer hashedWheelTimer, FeatureProvider featureProvider, - StatsLogger statsLogger); + StatsLogger statsLogger) { + return initialize(conf); + } + + /** * Uninitialize the policy */ - public void uninitalize(); + public default void uninitalize() { Review comment: any reason to make it default. personally the implementation should take care of initialize and uninitialize. so they should not be 'default'. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services