sijie commented on a change in pull request #301: Issue-299
EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129655166
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java
##########
@@ -50,16 +55,21 @@
* @param featureProvider feature provider
* @param statsLogger stats logger
*/
- public EnsemblePlacementPolicy initialize(ClientConfiguration conf,
+ public default EnsemblePlacementPolicy initialize(ClientConfiguration conf,
Optional<DNSToSwitchMapping>
optionalDnsResolver,
HashedWheelTimer
hashedWheelTimer,
FeatureProvider featureProvider,
- StatsLogger statsLogger);
+ StatsLogger statsLogger) {
+ return initialize(conf);
Review comment:
Can you just return 'this' here? and implement initilize(conf) by calling
initialize(conf, Optional.empty(), null, NullFeatureProvider.INSTANCe,
NullStatsLogger.INSTANCE). because initialize(conf) is a legacy method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
