sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129651443
########## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/GenericEnsemblePlacementPolicyTest.java ########## @@ -132,9 +132,9 @@ public void testReplaceBookie() throws Exception { lh.addEntry(value); } } - assertEquals(2, customMetadataOnNewEnsembleStack.size()); Review comment: this seems to indicate this change changes the placement behavior. in order to keep binary backward compatible, I would think adding method overloading should be good enough, and it should not change the placement behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services