sijie commented on a change in pull request #301: Issue-299
EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129770165
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/GenericEnsemblePlacementPolicyTest.java
##########
@@ -132,9 +132,9 @@ public void testReplaceBookie() throws Exception {
lh.addEntry(value);
}
}
- assertEquals(2, customMetadataOnNewEnsembleStack.size());
Review comment:
@eolivelli I don't know what others will be impacted. I do not see such
binary compatibility issue a lot, because typically when a new version is
available, most of the people would update their application with a newer
version and compile it. this would be detected as compilation issues and fixed.
Compilation issues are much safer and easier to deal with. In contrast, I
did see a lot of runtime exceptions when newer clients uses old dependencies
(when there aren't any troubles compiling new clients with old dependencies),
e.g. method signatures are changed, method not found, classes not found. Those
runtime exceptions are much dangerous than compilation issues.
>> are you ok with closing the issue as won't fix
I am fine with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
