+1 (binding) There are test failures on mac but I believe they fail only on mac (please double check). I briefly looked at these but had to stop/timed out.
What I did: * reviewed release notes (left some comments) * built/test from tag, Mac/Java 11 $ git checkout v4.16.0-rc2 $ mvn clean install -DskipTests $ mvn test Failures: 1. org.apache.bookkeeper.test.BookieZKExpireTest - added https://github.com/apache/bookkeeper/issues/3898 2. org.apache.bookkeeper.client.TestSpeculativeRead - added https://github.com/apache/bookkeeper/issues/3899 3. Direct entry logger tests fail on mac (probably by design but tests should handle this / don't run on mac) - added https://github.com/apache/bookkeeper/issues/3897 * checked signatures (ok) and checksums (ok) $ cd ~/Downloads $ wget --no-parent -r https://dist.apache.org/repos/dist/dev/bookkeeper/ bookkeeper-4.16.0-rc2/ $ cd dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.0-rc2 $ gpg --keyserver hkps://pgp.mit.edu/ --search-keys "<release manager's email here>" $ for f in *.asc; do gpg --verify $f ${f%.*}; done All is good, there is a warning gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. I think you may need to "verify" your key, don't remember how. $ for f in *.tar.gz; do shasum -a 512 $f | diff $f.sha512 -; done * bin/bookkeeper standalone starts (from packaged binaries) * bin/bookkeeper localbookie 3 starts (from built binaries) * compared gzipped source with sources at tag (ok) * built from gzipped sources (didn't run the tests) On Wed, Mar 29, 2023 at 7:07 AM Hang Chen <chenh...@apache.org> wrote: > Hi everyone, > Please review and vote on the release candidate #2 for version 4.16.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.16.0-rc2" [4] with git sha [5] > > BookKeeper's KEYS file contains the PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review the maven repo, release tag, licenses, and any other things you > think > it is important to release. > > The vote will be open for at least 72 hours. It is adopted by the majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Release Manager > > [1] https://github.com/apache/bookkeeper/pull/3882/files > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.0-rc2/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1083/ > [4] https://github.com/apache/bookkeeper/tree/v4.16.0-rc2 > [5] 8890a61418e3961e0000108b3c2e8ea176691e5f > -- Andrey Yegorov
