I added the logs to the issue. FWIW I ran the tests from the command line, no from IntelliJ.
$ mvn -v Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /usr/local/Cellar/maven/3.8.6/libexec Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: /Users/andreyyegorov/Library/Java/JavaVirtualMachines/adopt-openjdk-11.0.11/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" On Fri, Mar 31, 2023 at 9:42 AM Hang Chen <chenh...@apache.org> wrote: > Hi Andrey, > Thanks for your great job! > > For the failed tests, > - org.apache.bookkeeper.test.BookieZKExpireTest is a test issue, and I > will fix it later. It is not a blocker for this release. > - org.apache.bookkeeper.client.TestSpeculativeRead, I have run the > test on my Mac multiple times, and they are all passed. Would you > please share the detailed logs with me? I think it also may not be a > blocker for this release. > - Direct entry logger tests fail on mac (probably by design, but tests > should handle this / don't run on mac). I replied under this issue > [1]. To make the tests run in the Intellij idea, we need to copy the > `libnative-io.jnilib` file to a target lib directory. After copying > the file, all the direct entry logger tests are passed on my Macbook. > > For the gpg warning, my gpg key has been signed by two guys [2]. I > have no idea why it still reports not certified with a trusted > signature. > > Thanks, > Hang > > [1] > https://github.com/apache/bookkeeper/issues/3897#issuecomment-1492138987 > [2] > https://urldefense.com/v3/__https://pgp.mit.edu/pks/lookup?op=vindex&search=0xA641378C97944D34__;!!PbtH5S7Ebw!ekniQYxhGs8shdCYecyXm2-Rz7C3Og-OW-oWG3SLnQdQ1Jc93wyFh9jiohPMukFz45zKvC3sz0n1OWIqugtVYMlb$ > > Andrey Yegorov <andrey.yego...@datastax.com> 于2023年3月31日周五 04:58写道： > > > > +1 (binding) > > > > There are test failures on mac but I believe they fail only on mac > (please > > double check). > > I briefly looked at these but had to stop/timed out. > > > > What I did: > > > > * reviewed release notes (left some comments) > > > > * built/test from tag, Mac/Java 11 > > > > $ git checkout v4.16.0-rc2 > > $ mvn clean install -DskipTests > > $ mvn test > > > > Failures: > > 1. org.apache.bookkeeper.test.BookieZKExpireTest - added > > https://github.com/apache/bookkeeper/issues/3898 > > 2. org.apache.bookkeeper.client.TestSpeculativeRead - added > > https://github.com/apache/bookkeeper/issues/3899 > > 3. Direct entry logger tests fail on mac (probably by design but tests > > should handle this / don't run on mac) - added > > https://github.com/apache/bookkeeper/issues/3897 > > > > * checked signatures (ok) and checksums (ok) > > > > $ cd ~/Downloads > > $ wget --no-parent -r https://dist.apache.org/repos/dist/dev/bookkeeper/ > > bookkeeper-4.16.0-rc2/ > > $ cd dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.0-rc2 > > $ gpg --keyserver hkps://pgp.mit.edu/ --search-keys "<release manager's > > email here>" > > $ for f in *.asc; do gpg --verify $f ${f%.*}; done > > > > All is good, there is a warning > > gpg: WARNING: This key is not certified with a trusted signature! > > gpg: There is no indication that the signature belongs to the > > owner. > > I think you may need to "verify" your key, don't remember how. > > > > $ for f in *.tar.gz; do shasum -a 512 $f | diff $f.sha512 -; done > > > > * bin/bookkeeper standalone starts (from packaged binaries) > > > > * bin/bookkeeper localbookie 3 starts (from built binaries) > > > > * compared gzipped source with sources at tag (ok) > > > > * built from gzipped sources (didn't run the tests) > > > > > > On Wed, Mar 29, 2023 at 7:07 AM Hang Chen <chenh...@apache.org> wrote: > > > > > Hi everyone, > > > Please review and vote on the release candidate #2 for version 4.16.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.16.0-rc2" [4] with git sha [5] > > > > > > BookKeeper's KEYS file contains the PGP keys we used to sign this > release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review the maven repo, release tag, licenses, and any other things > you > > > think > > > it is important to release. > > > > > > The vote will be open for at least 72 hours. It is adopted by the > majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] https://github.com/apache/bookkeeper/pull/3882/files > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.0-rc2/ > > > [3] > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1083/ > > > [4] https://github.com/apache/bookkeeper/tree/v4.16.0-rc2 > > > [5] 8890a61418e3961e0000108b3c2e8ea176691e5f > > > > > > > > > -- > > Andrey Yegorov > -- Andrey Yegorov
