The vote is now closed, and the release was approved with 3 +1s(3 bindings), and I will continue with the following steps.
Binding votes: * Andrey Yegorov * Matteo Merli * Enrico Olivelli Thank you all for verifying and voting! Thanks, Hang Enrico Olivelli <eolive...@gmail.com> 于2023年4月7日周五 14:42写道： > > +1 (binding) > > - Built and run tests locally on jdk11 on M1 > - Run smoke tests > - Verified checksum and signatures > > > Enrico > > Il Sab 1 Apr 2023, 08:35 Andrey Yegorov <andrey.yego...@datastax.com> ha > scritto: > > > > Have you ever run `mvn clean insteall -DskipTests` before > > running the tests > > > > of course. > > > > as listed above: > > $ git checkout v4.16.0-rc2 > > $ mvn clean install -DskipTests > > $ mvn test > > > > On Fri, Mar 31, 2023 at 8:19 PM Hang Chen <chenh...@apache.org> wrote: > > > > > > I added the logs to the issue. > > > > > > It looks like the loopback address problem, and the Bookie server does > > > not allow loopback interfaces as the primary interface. You can set > > > allowLoopback to true and rerun the test. > > > > > > > > > > FWIW I ran the tests from the command line, no from IntelliJ. > > > > > > >$ mvn -v > > > >Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > > >Maven home: /usr/local/Cellar/maven/3.8.6/libexec > > > >Java version: 11.0.11, vendor: AdoptOpenJDK, runtime: > > > > > > > > >/Users/andreyyegorov/Library/Java/JavaVirtualMachines/adopt-openjdk-11.0.11/Contents/Home > > > >Default locale: en_US, platform encoding: UTF-8 > > > >OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" > > > > > > I ran the test from the command line without any changes, and the tests > > > passed. > > > $ mvn test -Dtest=DbLedgerStorageWithDirectEntryLoggerTest > > > [INFO] Running > > > > > org.apache.bookkeeper.bookie.storage.ldb.DbLedgerStorageWithDirectEntryLoggerTest > > > [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time > > > elapsed: 16.021 s - in > > > > > > > > org.apache.bookkeeper.bookie.storage.ldb.DbLedgerStorageWithDirectEntryLoggerTest > > > > > > $ mvn -v > > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > > Maven home: /Users/hangc/Cloud/apache-maven-3.8.6 > > > Java version: 11.0.12, vendor: Oracle Corporation, runtime: > > > /Library/Java/JavaVirtualMachines/jdk-11.0.12.jdk/Contents/Home > > > Default locale: en_CN, platform encoding: UTF-8 > > > OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" > > > > > > @Andrey Have you ever run `mvn clean insteall -DskipTests` before > > > running the tests? > > > > > > Thanks, > > > Hang > > > > > > Matteo Merli <matteo.me...@gmail.com> 于2023年4月1日周六 01:32写道： > > > > > > > > +1 binding > > > > > > > > * Checked signatures > > > > * Check localbookie and local perf tool > > > > > > > > > > > > > > > > -- > > > > Matteo Merli > > > > <matteo.me...@gmail.com> > > > > > > > > > > > > On Wed, Mar 29, 2023 at 7:06 AM Hang Chen <chenh...@apache.org> wrote: > > > > > > > > > Hi everyone, > > > > > Please review and vote on the release candidate #2 for version > > 4.16.0, > > > > > as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * Release notes [1] > > > > > * The official Apache source and binary distributions to be deployed > > to > > > > > dist.apache.org [2] > > > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > > > * Source code tag "v4.16.0-rc2" [4] with git sha [5] > > > > > > > > > > BookKeeper's KEYS file contains the PGP keys we used to sign this > > > release: > > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > > > > > Please download these packages and review this release candidate: > > > > > > > > > > - Review release notes > > > > > - Download the source package (verify shasum, and asc) and follow the > > > > > instructions to build and run the bookkeeper service. > > > > > - Download the binary package (verify shasum, and asc) and follow the > > > > > instructions to run the bookkeeper service. > > > > > - Review the maven repo, release tag, licenses, and any other things > > > you > > > > > think > > > > > it is important to release. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by the > > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Release Manager > > > > > > > > > > [1] https://github.com/apache/bookkeeper/pull/3882/files > > > > > [2] > > > > > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.0-rc2/ > > > > > [3] > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1083/ > > > > > [4] https://github.com/apache/bookkeeper/tree/v4.16.0-rc2 > > > > > [5] 8890a61418e3961e0000108b3c2e8ea176691e5f > > > > > > > > > > > > > > -- > > Andrey Yegorov > >
