Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/740#discussion_r124323919
--- Diff:
utils/common/src/test/java/org/apache/brooklyn/util/text/VersionComparatorTest.java
---
@@ -56,40 +35,51 @@ public void testSnapshotSuffixComparison() {
@Test
public void testComparison() {
--- End diff --
BTW the tests would need to be careful to supply actually different String
objects, to avoid hitting the `if (Objects.equal(v1, v2)) return 0;`
[here](https://github.com/apache/brooklyn-server/pull/743/files#diff-a66acd1b299b8d264a4c2c6f052b27c5R77).
We'd want to be sure to exercise the code below that test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
