Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/740#discussion_r124510504
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/NaturalOrderComparator.java
---
@@ -140,6 +147,32 @@ public int compare(String a, String b) {
if ((result = compareRight(a.substring(ia),
b.substring(ib))) != 0) {
return result;
}
+ // numeric portion is the same; previously we incremented
and checked again
--- End diff --
i noticed some behaviour which i thought was undesired behaviour of
`NaturalOrderComparator`, as indicated by the new tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
