Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/740#discussion_r124512975
--- Diff:
utils/common/src/test/java/org/apache/brooklyn/util/text/VersionComparatorTest.java
---
@@ -56,40 +35,51 @@ public void testSnapshotSuffixComparison() {
@Test
public void testComparison() {
--- End diff --
as above, i think the comparators should never return 0 unless the strings
are actually equal; someone else has determined equality beforehand, and wants
this to give a canonical order on the things it thinks are unequal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
