+1 But more important is what the mentors think!
Some minor comments: * https://people.apache.org/~richard/community/how-to-contribute.html: o "ready to be merged once it gets at lease one +1 from a reviewer" This should be "from a committer" I presume? o "It is also a good idea to squash all the commits into a single one, since this will allow us to generate a clean patch and merge it properly" Wording feels too strong, I think. If it is a series of logical steps (that don't justify separate PRs) then separate commits are fine. Could reword to "consider squashing all the commits into a single one where appropriate, since..." Also, committers won't be generating patches I presume - the committer proposal is to do `git merge pull/github/1234; git push apache master`. Aled On 09/06/2014 23:39, Richard Downer wrote:
All, Following our earlier proposal for source code contributions using GitHub, here is a revised position which reflects our mentor's advice. TL;DR - it's similar to the last one, except that the normal working mirror will be https://github.com/apache/incubator-brooklyn, and no other GitHub organisations are involved. The process for contributors is described here: https://people.apache.org/~richard/community/how-to-contribute.html [Note that this URL is temporary, until docs go live at our official web site] In short, contributors submit PRs against https://github.com/apache/incubator-brooklyn, the remainder of the document describes some best practices and an explanation of the review process as a contributor would see it. The process for committers is described here: https://people.apache.org/~richard/community/committers.html [Note that this URL is temporary, until docs go live at our official web site] This documents a workflow that involves setting up a local repository that refers to both the canonical Apache repository (https://git-wip-us.apache.org/repos/asf/incubator-brooklyn.git) and the GitHub mirror, and describes how to merge pull requests from GitHub mirror and push them to the canonical repo. Any comments / votes? Thanks Richard.
